Skip to content

fix(migrations): cf migration - fix bug in attribute formatting#53636

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:attribute-fix
Closed

fix(migrations): cf migration - fix bug in attribute formatting#53636
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:attribute-fix

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

The formatting that would preserve attribute indents completely missed attributes that start on new lines rather than the same line as the opening element.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

The formatting that would preserve attribute indents completely missed attributes that start on new lines rather than the same line as the opening element.
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Dec 19, 2023
@ngbot ngbot bot modified the milestone: Backlog Dec 19, 2023
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 19, 2023
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Dec 19, 2023

This PR was merged into the repository by commit 22b95de.

atscott pushed a commit that referenced this pull request Dec 19, 2023
The formatting that would preserve attribute indents completely missed attributes that start on new lines rather than the same line as the opening element.

PR Close #53636
@atscott atscott closed this in 22b95de Dec 19, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 19, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…lar#53636)

The formatting that would preserve attribute indents completely missed attributes that start on new lines rather than the same line as the opening element.

PR Close angular#53636
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
…lar#53636)

The formatting that would preserve attribute indents completely missed attributes that start on new lines rather than the same line as the opening element.

PR Close angular#53636
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
…lar#53636)

The formatting that would preserve attribute indents completely missed attributes that start on new lines rather than the same line as the opening element.

PR Close angular#53636
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants