Skip to content

fix(migrations): cf migration - stop removing empty newlines from i18n blocks#53578

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:i18n-format
Closed

fix(migrations): cf migration - stop removing empty newlines from i18n blocks#53578
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:i18n-format

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk commented Dec 14, 2023

Since i18n sections are whitespace sensitive, we should avoid removing empty lines when inside an i18n block that were present before.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman
fix(migrations): cf migration - stop removing empty newlines from i18…
12c7afd 
…n blocks

Since i18n sections are whitespace sensitive, we should avoid removing empty lines when inside an i18n block that were present before.
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Dec 14, 2023
@ngbot ngbot bot modified the milestone: Backlog Dec 14, 2023
AndrewKushnir
AndrewKushnir approved these changes Dec 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 15, 2023
@ngbot
Copy link
Copy Markdown

ngbot bot commented Dec 15, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jessicajaniuk
Copy link
Copy Markdown
Contributor Author

jessicajaniuk commented Dec 15, 2023

This PR was merged into the repository by commit 7bb312f.

jessicajaniuk pushed a commit that referenced this pull request Dec 15, 2023
@thePunderWoman
fix(migrations): cf migration - stop removing empty newlines from i18…
e73205f 
…n blocks (#53578)

Since i18n sections are whitespace sensitive, we should avoid removing empty lines when inside an i18n block that were present before.

PR Close #53578
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Jan 15, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 15, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@thePunderWoman @ChellappanRajan
fix(migrations): cf migration - stop removing empty newlines from i18…
5839a9a 
…n blocks (angular#53578)

Since i18n sections are whitespace sensitive, we should avoid removing empty lines when inside an i18n block that were present before.

PR Close angular#53578
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @rlmestre
fix(migrations): cf migration - stop removing empty newlines from i18…
82dbaeb 
…n blocks (angular#53578)

Since i18n sections are whitespace sensitive, we should avoid removing empty lines when inside an i18n block that were present before.

PR Close angular#53578
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@thePunderWoman @amilamen
fix(migrations): cf migration - stop removing empty newlines from i18…
809f573 
…n blocks (angular#53578)

Since i18n sections are whitespace sensitive, we should avoid removing empty lines when inside an i18n block that were present before.

PR Close angular#53578
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@jessicajaniuk @AndrewKushnir @thePunderWoman