Skip to content

ci: Add primitives group to pullapprove#53404

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:signals-pullapprove
Closed

ci: Add primitives group to pullapprove#53404
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:signals-pullapprove

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

This adds the shared primitives reviewers groups and list of reviewers to the pullapprove rules.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 6, 2023
@ngbot ngbot Bot added this to the Backlog milestone Dec 6, 2023
@jessicajaniuk jessicajaniuk requested a review from alxhub December 6, 2023 19:00
@jessicajaniuk jessicajaniuk force-pushed the signals-pullapprove branch 2 times, most recently from ba047bc to 632f28c Compare March 25, 2024 18:03
@dylhunn dylhunn self-requested a review March 27, 2024 16:26
Copy link
Copy Markdown
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core

Comment thread .pullapprove.yml Outdated
This adds the shared primitives reviewers groups and list of reviewers
to the pullapprove rules.
@jessicajaniuk jessicajaniuk removed the request for review from josephperrott April 2, 2024 22:47
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 2, 2024
jessicajaniuk pushed a commit that referenced this pull request Apr 3, 2024
This adds the shared primitives reviewers groups and list of reviewers
to the pullapprove rules.

PR Close #53404
@jessicajaniuk
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit 2ff74dc.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 4, 2024
@pullapprove pullapprove Bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants