Skip to content

Fix some typos throughout the codebase#52826

Closed
ranma42 wants to merge 1 commit intoangular:mainfrom
ranma42:fix/adev-typos
Closed

Fix some typos throughout the codebase#52826
ranma42 wants to merge 1 commit intoangular:mainfrom
ranma42:fix/adev-typos

Conversation

@ranma42
Copy link
Copy Markdown
Contributor

@ranma42 ranma42 commented Nov 12, 2023 •
edited by JeanMeche
Loading

Fix several typos, mostly in the adev site.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The codebase contains some typos.

Issue Number: fixes #52825

What is the new behavior?

The codebase contains some less typos :)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ranma42
Copy link
Copy Markdown
Contributor Author

ranma42 commented Nov 12, 2023 •
edited
Loading

This is basically another iteration of spellchecking, like

😇

@ranma42 ranma42 changed the title Fix a some typos throughout the codebase Fix some typos throughout the codebase Nov 12, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 13, 2023
devversion
devversion approved these changes Nov 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dev-infra and schematics

@devversion devversion requested a review from twerske November 14, 2023 11:48
@twerske
Copy link
Copy Markdown
Contributor

twerske commented Nov 29, 2023

Adding blocked until we can build a preview of the Angular.dev app in this PR!

@twerske twerske added the target: patch This PR is targeted for the next patch release label Nov 29, 2023
@ranma42
Copy link
Copy Markdown
Contributor Author

ranma42 commented Nov 30, 2023

uh, I just noticed that there are some conflicts; should I rebase the PR? 🤔 maybe it makes more sense to do that when it is not blocked anymore

@ranma42
Copy link
Copy Markdown
Contributor Author

ranma42 commented Jan 6, 2024

any news here?

@jelbourn
Copy link
Copy Markdown
Contributor

jelbourn commented Jan 18, 2024

@ranma42 yeah, it probably makes sense to rebase this once we've unblocked merging PRs for angular.dev (which will hopefully be soon)

@ranma42
refactor: fix a number of typos throughout the codebase
078f7a1 
Fix several typos, mostly in the `adev` site.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 21, 2024

Deployed adev-preview for 078f7a1 to: https://ng-dev-previews-fw--pr-angular-angular-52826-adev-prev-4qxw5uz2.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

jessicajaniuk
jessicajaniuk approved these changes Jan 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 25, 2024
@jessicajaniuk
Copy link
Copy Markdown
Contributor

jessicajaniuk commented Jan 25, 2024

Caretaker note: Current approvals are sufficient. This is a low risk PR with just spelling changes.

jessicajaniuk pushed a commit that referenced this pull request Jan 25, 2024
@ranma42 @thePunderWoman
refactor: fix a number of typos throughout the codebase (#52826)
96dd0c7 
Fix several typos, mostly in the `adev` site.

PR Close #52826
@jessicajaniuk
Copy link
Copy Markdown
Contributor

jessicajaniuk commented Jan 25, 2024

This PR was merged into the repository by commit ecbb47b.

rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
@ranma42 @rlmestre
refactor: fix a number of typos throughout the codebase (angular#52826)
a127a8f 
Fix several typos, mostly in the `adev` site.

PR Close angular#52826
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
@ranma42 @amilamen
refactor: fix a number of typos throughout the codebase (angular#52826)
3355b79 
Fix several typos, mostly in the `adev` site.

PR Close angular#52826
nikvarma pushed a commit to nikvarma/angular that referenced this pull request Jan 31, 2024
@ranma42 @nikvarma
refactor: fix a number of typos throughout the codebase (angular#52826)
ed1f925 
Fix several typos, mostly in the `adev` site.

PR Close angular#52826
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Feb 25, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2024
@ranma42 ranma42 deleted the fix/adev-typos branch April 27, 2024 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

+1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Docs (angular.dev): Minor typo in Property Binding tutorial

6 participants

@ranma42 @twerske @jelbourn @jessicajaniuk @devversion @JeanMeche