Skip to content

Cherry-pick revert of in-memory-web-api changes to v17 branch#52630

Closed
alxhub wants to merge 1 commit intoangular:17.0.xfrom
alxhub:revert-in-memory-v17
Closed

Cherry-pick revert of in-memory-web-api changes to v17 branch#52630
alxhub wants to merge 1 commit intoangular:17.0.xfrom
alxhub:revert-in-memory-v17

Conversation

@alxhub
Copy link
Copy Markdown
Member

@alxhub alxhub commented Nov 8, 2023

This reverts commit 49b037f. Reason: it breaks tests in aio-local.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alxhub
Revert "fix(http): Don't override the backend when using the InMemory…
169f4b7 
…WebAPI (angular#52425)"

This reverts commit 49b037f. Reason: it
breaks tests in aio-local.
@pullapprove pullapprove bot requested a review from atscott November 8, 2023 13:49
@alxhub alxhub added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release PullApprove: disable labels Nov 8, 2023
@pkozlowski-opensource pkozlowski-opensource removed the request for review from atscott November 8, 2023 14:52
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Nov 8, 2023

This PR was merged into the repository by commit da429c5.

pkozlowski-opensource pushed a commit that referenced this pull request Nov 8, 2023
@alxhub @pkozlowski-opensource
Revert "fix(http): Don't override the backend when using the InMemory…
da429c5 
…WebAPI (#52425)" (#52630)

This reverts commit 49b037f. Reason: it
breaks tests in aio-local.

PR Close #52630
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Dec 9, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxhub @pkozlowski-opensource @crisbeto @devversion