fix(compiler): ng-template directive invoke twice at the root of control flow#52515
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): ng-template directive invoke twice at the root of control flow#52515crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
…rol flow Discovered this while validating angular#52414 against Angular Material. We were projecting `<ng-template>` nodes at the root of `@if` and `@for` with the `ng-template` tag name which enables directive matching and applies the directive to the control flow node. These changes fix the issue by never passing along the `ng-template` tag name.
dylhunn
approved these changes
Nov 6, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
Makes sense, and thanks for also fixing template pipeline!
Contributor
|
This PR was merged into the repository by commit 9cfd35a. |
atscott
pushed a commit
that referenced
this pull request
Nov 6, 2023
…rol flow (#52515) Discovered this while validating #52414 against Angular Material. We were projecting `<ng-template>` nodes at the root of `@if` and `@for` with the `ng-template` tag name which enables directive matching and applies the directive to the control flow node. These changes fix the issue by never passing along the `ng-template` tag name. PR Close #52515
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…rol flow (angular#52515) Discovered this while validating angular#52414 against Angular Material. We were projecting `<ng-template>` nodes at the root of `@if` and `@for` with the `ng-template` tag name which enables directive matching and applies the directive to the control flow node. These changes fix the issue by never passing along the `ng-template` tag name. PR Close angular#52515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this while validating #52414 against Angular Material. We were projecting
<ng-template>nodes at the root of@ifand@forwith theng-templatetag name which enables directive matching and applies the directive to the control flow node.These changes fix the issue by never passing along the
ng-templatetag name.