Skip to content

build: configure cross-pkg resolution for api extraction#52499

Closed
jelbourn wants to merge 1 commit intoangular:mainfrom
jelbourn:extraction-cross-package
Closed

build: configure cross-pkg resolution for api extraction#52499
jelbourn wants to merge 1 commit intoangular:mainfrom
jelbourn:extraction-cross-package

Conversation

@jelbourn
Copy link
Contributor

@jelbourn jelbourn commented Nov 2, 2023

This commit adds path mapping and source dependencies necessary to fully resolve types during api doc extraction.

@jelbourn jelbourn added the area: build & ci Related the build and CI infrastructure of the project label Nov 2, 2023
@ngbot ngbot bot added this to the Backlog milestone Nov 2, 2023
@pullapprove pullapprove bot requested review from AndrewKushnir and alxhub November 2, 2023 21:59
@jelbourn jelbourn added the target: rc This PR is targeted for the next release-candidate label Nov 2, 2023
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Nov 9, 2023
@pullapprove pullapprove bot requested review from AndrewKushnir and alxhub November 9, 2023 00:59
This commit adds path mapping and source dependencies necessary to fully
resolve types during api doc extraction.
@jelbourn jelbourn force-pushed the extraction-cross-package branch from b8a384e to 2958d47 Compare January 3, 2024 21:28
@jelbourn
Copy link
Contributor Author

jelbourn commented Jan 3, 2024

@AndrewKushnir came back to fix this up after the holidays, should be good to go now

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 5, 2024
@jelbourn
Copy link
Contributor Author

jelbourn commented Jan 5, 2024

Caretaker note: Current set of approvals should be good since this is all build/docs changes rather than framework code

@atscott
Copy link
Contributor

atscott commented Jan 5, 2024

This PR was merged into the repository by commit 91f250d.

@atscott atscott closed this in 91f250d Jan 5, 2024
atscott pushed a commit that referenced this pull request Jan 5, 2024
This commit adds path mapping and source dependencies necessary to fully
resolve types during api doc extraction.

PR Close #52499
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
This commit adds path mapping and source dependencies necessary to fully
resolve types during api doc extraction.

PR Close angular#52499
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
This commit adds path mapping and source dependencies necessary to fully
resolve types during api doc extraction.

PR Close angular#52499
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
This commit adds path mapping and source dependencies necessary to fully
resolve types during api doc extraction.

PR Close angular#52499
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants