refactor(animations): use existing helper methods. by JeanMeche · Pull Request #52441 · angular/angular

JeanMeche · 2023-10-29T10:50:51Z

Saving a few bytes...

The changes are split over several commits in case we want to drop one.

packages/animations/browser/src/dsl/animation_transition_factory.ts

packages/animations/browser/src/util.ts

goldens/size-tracking/integration-payloads.json

jessicajaniuk

LGTM

reviewed-for: fw-core, fw-animations, size-tracking

alan-agius4 · 2023-12-14T14:25:13Z

@JeanMeche can you please rebase so that I can trigger a presubmit?

Saving a few bytes.

… an array. Using the spread operator is the fastest way to convert an iterable to an array.

Using the spread operator is the fastest way to shallow copy an object.

…ve functions. `copyStyles` was side-effectful and also returned a value : not great.

JeanMeche · 2023-12-14T14:29:42Z

@alan-agius4 ✅

alan-agius4 · 2023-12-14T14:55:27Z

TGP

alan-agius4 · 2023-12-14T18:07:21Z

TGP green after deflake
https://fusion2.corp.google.com/presubmit/590925503/OCL:590925503:BASE:590966781:1702575524261:ad883587/targets

atscott · 2023-12-14T20:33:26Z

This PR was merged into the repository by commit d7e7409.

… an array. (#52441) Using the spread operator is the fastest way to convert an iterable to an array. PR Close #52441

…j` (#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close #52441

…ve functions. (#52441) `copyStyles` was side-effectful and also returned a value : not great. PR Close #52441

Saving a few bytes. PR Close angular#52441

… an array. (angular#52441) Using the spread operator is the fastest way to convert an iterable to an array. PR Close angular#52441

…j` (angular#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close angular#52441

…ve functions. (angular#52441) `copyStyles` was side-effectful and also returned a value : not great. PR Close angular#52441

angular-automatic-lock-bot · 2024-01-24T00:08:58Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Saving a few bytes. PR Close angular#52441

… an array. (angular#52441) Using the spread operator is the fastest way to convert an iterable to an array. PR Close angular#52441

…j` (angular#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close angular#52441

…ve functions. (angular#52441) `copyStyles` was side-effectful and also returned a value : not great. PR Close angular#52441

Saving a few bytes. PR Close angular#52441

… an array. (angular#52441) Using the spread operator is the fastest way to convert an iterable to an array. PR Close angular#52441

…j` (angular#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close angular#52441

…ve functions. (angular#52441) `copyStyles` was side-effectful and also returned a value : not great. PR Close angular#52441

JeanMeche marked this pull request as ready for review October 29, 2023 11:29

pullapprove bot requested a review from jessicajaniuk October 29, 2023 11:29

JeanMeche force-pushed the animations-getComputedStyle branch 2 times, most recently from 40d17f3 to d06df19 Compare October 29, 2023 13:13

JoostK reviewed Oct 29, 2023

View reviewed changes

packages/animations/browser/src/dsl/animation_transition_factory.ts Outdated Show resolved Hide resolved

JeanMeche force-pushed the animations-getComputedStyle branch 5 times, most recently from 22f2c4e to 3b9c8fd Compare October 29, 2023 20:51

alan-agius4 reviewed Oct 30, 2023

View reviewed changes

packages/animations/browser/src/util.ts Show resolved Hide resolved

alan-agius4 reviewed Oct 30, 2023

View reviewed changes

goldens/size-tracking/integration-payloads.json Show resolved Hide resolved

jessicajaniuk approved these changes Oct 30, 2023

View reviewed changes

pullapprove bot requested review from AndrewKushnir and pkozlowski-opensource October 30, 2023 14:18

jessicajaniuk removed request for AndrewKushnir and pkozlowski-opensource October 30, 2023 14:19

jessicajaniuk added area: animations target: rc This PR is targeted for the next release-candidate action: global presubmit The PR is in need of a google3 global presubmit labels Oct 30, 2023

ngbot bot added this to the Backlog milestone Oct 30, 2023

alan-agius4 added target: minor This PR is targeted for the next minor release and removed target: rc This PR is targeted for the next release-candidate labels Dec 14, 2023

JeanMeche added 4 commits December 14, 2023 15:28

refactor(animations): use existing helper methods.

2c6eb02

Saving a few bytes.

refactor(animations): use a spread operator to convert an iterable to…

542d2b5

… an array. Using the spread operator is the fastest way to convert an iterable to an array.

refactor(animations): use a spread operator instead of custom copyObj

4c7321a

Using the spread operator is the fastest way to shallow copy an object.

refactor(animations): drop convertToMap & copyStyles and use nati…

d07660c

…ve functions. `copyStyles` was side-effectful and also returned a value : not great.

JeanMeche force-pushed the animations-getComputedStyle branch from 3b9c8fd to d07660c Compare December 14, 2023 14:28

alan-agius4 self-assigned this Dec 14, 2023

alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit labels Dec 14, 2023

alan-agius4 removed their assignment Dec 14, 2023

atscott closed this in 635c3b4 Dec 14, 2023

atscott pushed a commit that referenced this pull request Dec 14, 2023

refactor(animations): use a spread operator to convert an iterable to…

6a347d3

… an array. (#52441) Using the spread operator is the fastest way to convert an iterable to an array. PR Close #52441

atscott pushed a commit that referenced this pull request Dec 14, 2023

refactor(animations): use a spread operator instead of custom `copyOb…

d28ce0a

…j` (#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close #52441

atscott pushed a commit that referenced this pull request Dec 14, 2023

refactor(animations): drop convertToMap & copyStyles and use nati…

d7e7409

…ve functions. (#52441) `copyStyles` was side-effectful and also returned a value : not great. PR Close #52441

JeanMeche deleted the animations-getComputedStyle branch December 24, 2023 14:36

ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024

refactor(animations): use existing helper methods. (angular#52441)

a94fec7

Saving a few bytes. PR Close angular#52441

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 24, 2024

rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024

refactor(animations): use existing helper methods. (angular#52441)

24bb7c2

Saving a few bytes. PR Close angular#52441

rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024

refactor(animations): use a spread operator instead of custom `copyOb…

ad8d19b

…j` (angular#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close angular#52441

amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024

refactor(animations): use existing helper methods. (angular#52441)

2e543b2

Saving a few bytes. PR Close angular#52441

amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024

refactor(animations): use a spread operator instead of custom `copyOb…

e264145

…j` (angular#52441) Using the spread operator is the fastest way to shallow copy an object. PR Close angular#52441

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(animations): use existing helper methods.#52441

refactor(animations): use existing helper methods.#52441
JeanMeche wants to merge 4 commits intomainfrom
animations-getComputedStyle

JeanMeche commented Oct 29, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jessicajaniuk left a comment •

edited

Loading

Uh oh!

alan-agius4 commented Dec 14, 2023

Uh oh!

JeanMeche commented Dec 14, 2023

Uh oh!

alan-agius4 commented Dec 14, 2023

Uh oh!

alan-agius4 commented Dec 14, 2023

Uh oh!

atscott commented Dec 14, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jan 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JeanMeche commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jessicajaniuk left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alan-agius4 commented Dec 14, 2023

Uh oh!

JeanMeche commented Dec 14, 2023

Uh oh!

alan-agius4 commented Dec 14, 2023

Uh oh!

alan-agius4 commented Dec 14, 2023

Uh oh!

atscott commented Dec 14, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jan 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JeanMeche commented Oct 29, 2023 •

edited

Loading

jessicajaniuk left a comment •

edited

Loading