Skip to content

refactor(language-service): Add quick info for built in control flow/…#52386

Closed
atscott wants to merge 3 commits intoangular:mainfrom
atscott:quickinfo
Closed

refactor(language-service): Add quick info for built in control flow/…#52386
atscott wants to merge 3 commits intoangular:mainfrom
atscott:quickinfo

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Oct 25, 2023

…blocks

Adds hover info for:

  • Defer blocks
  • Triggers and trigger behavior keywords
  • For loop empty block
  • Track keyword in for loop block

resolves angular/vscode-ng-language-service#1946

…blocks

Adds hover info for:

* Defer blocks
* Triggers and trigger behavior keywords
* For loop empty block
* Track keyword in for loop block

resolves angular/vscode-ng-language-service#1946
@atscott atscott requested a review from crisbeto October 26, 2023 17:55
@atscott atscott marked this pull request as ready for review October 26, 2023 17:55
@atscott atscott added action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service and removed action: merge The PR is ready for merge by the caretaker labels Oct 26, 2023
@ngbot ngbot bot added this to the Backlog milestone Oct 26, 2023
@atscott atscott force-pushed the quickinfo branch 2 times, most recently from c86b9a6 to 6b69a77 Compare October 26, 2023 19:51
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Oct 30, 2023
@atscott atscott modified the milestones: Backlog, v17-final Oct 30, 2023
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Oct 31, 2023

This PR was merged into the repository by commit bf5bda4.

alxhub pushed a commit that referenced this pull request Oct 31, 2023
…blocks (#52386)

Adds hover info for:

* Defer blocks
* Triggers and trigger behavior keywords
* For loop empty block
* Track keyword in for loop block

resolves angular/vscode-ng-language-service#1946

PR Close #52386
@alxhub alxhub closed this in bf5bda4 Oct 31, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…blocks (angular#52386)

Adds hover info for:

* Defer blocks
* Triggers and trigger behavior keywords
* For loop empty block
* Track keyword in for loop block

resolves angular/vscode-ng-language-service#1946

PR Close angular#52386
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooltips for control flow syntax

3 participants