Skip to content

feat(language-service): Support autocompletion for blocks#52121

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:ls-blocks
Closed

feat(language-service): Support autocompletion for blocks#52121
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:ls-blocks

Conversation

@dylhunn
Copy link
Copy Markdown
Contributor

@dylhunn dylhunn commented Oct 9, 2023

This commit introduces basic autocompletion support for the new block keywords. After typing @, the language service suggests the various block names.

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Oct 9, 2023
@dylhunn dylhunn requested a review from atscott October 9, 2023 21:44
@ngbot ngbot bot modified the milestone: Backlog Oct 9, 2023
@dylhunn dylhunn changed the title feat(language-service: Support autocompletion for blocks feat(language-service): Support autocompletion for blocks Oct 9, 2023
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 9, 2023
@dylhunn dylhunn mentioned this pull request Oct 9, 2023
Merged
@dylhunn
Copy link
Copy Markdown
Contributor Author

dylhunn commented Oct 9, 2023 •
edited
Loading

caretaker: change does not affect g3. Windows is a flake

@dylhunn
feat(language-service): Support autocompletion for blocks
a026bee 
This commit introduces basic autocompletion support for the new block keywords. After typing `@`, the language service suggests the various block names.
@dylhunn dylhunn modified the milestones: Backlog, v17-candidates Oct 10, 2023
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 10, 2023
@dylhunn dylhunn added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 10, 2023
@angular-robot angular-robot bot closed this in 7c052bb Oct 10, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Nov 11, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@dylhunn @ChellappanRajan
feat(language-service): Support autocompletion for blocks (angular#52121
7782ef0 
)

This commit introduces basic autocompletion support for the new block keywords. After typing `@`, the language service suggests the various block names.

PR Close angular#52121
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

v17-candidates

Development

Successfully merging this pull request may close these issues.

2 participants

@dylhunn @atscott