Skip to content

fix(compiler): allow nullable values in for loop block#51997

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:51993/for-loop-nullable
Closed

fix(compiler): allow nullable values in for loop block#51997
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:51993/for-loop-nullable

Conversation

@crisbeto
Copy link
Copy Markdown
Member

@crisbeto crisbeto commented Oct 3, 2023

Updates the TCB for @for loop blocks to allow nullable values. The runtime already supports it and this makes it easier to switch from NgFor.

Fixes #51993.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 3, 2023
@crisbeto crisbeto added this to the v17-candidates milestone Oct 3, 2023
@crisbeto crisbeto requested a review from dylhunn October 3, 2023 09:56
@ngbot ngbot bot removed this from the v17-candidates milestone Oct 3, 2023
@crisbeto crisbeto removed the request for review from dylhunn October 3, 2023 16:16
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 3, 2023
@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2023
@crisbeto crisbeto modified the milestones: Backlog, v17-candidates Oct 3, 2023
Updates the TCB for `@for` loop blocks to allow nullable values. The runtime already supports it and this makes it easier to switch from `NgFor`.

Fixes angular#51993.
@crisbeto crisbeto force-pushed the 51993/for-loop-nullable branch from 9c5a3ff to f48fdb2 Compare October 4, 2023 01:28
@alxhub
Copy link
Copy Markdown
Member

alxhub commented Oct 4, 2023

This PR was merged into the repository by commit 0eae992.

@alxhub alxhub closed this in 0eae992 Oct 4, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
Updates the TCB for `@for` loop blocks to allow nullable values. The runtime already supports it and this makes it easier to switch from `NgFor`.

Fixes angular#51993.

PR Close angular#51997
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@for with async - Object is possible null

3 participants