[15.2.x] fix(service-worker): throw a critical error when handleFetch fail#51989
Closed
JeanMeche wants to merge 1 commit intoangular:15.2.xfrom
Closed
[15.2.x] fix(service-worker): throw a critical error when handleFetch fail#51989JeanMeche wants to merge 1 commit intoangular:15.2.xfrom
JeanMeche wants to merge 1 commit intoangular:15.2.xfrom
Conversation
This commit is a backport to 15.2 of angular#51960 and angular#50378 Throwing `SwCriticalError` allows the driver to fallback to `safeFetch` and ensure responseWith doesn't fail. Fixes angular#50378
AndrewKushnir
approved these changes
Oct 2, 2023
Contributor
|
Caretaker note: this PR targets LTS branch, we'd need to cut an LTS release once it's merged. |
alxhub
approved these changes
Oct 4, 2023
Member
|
This PR was merged into the repository by commit 9fe0896. |
alxhub
pushed a commit
that referenced
this pull request
Oct 4, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a backport to 15.2 of #51960 and #50378
Throwing
SwCriticalErrorallows the driver to fallback tosafeFetchand ensure responseWith doesn't fail.Fixes #50378