Support for implicit deferred triggers and better diagnostics for triggers#51922
Closed
crisbeto wants to merge 2 commits intoangular:mainfrom
Closed
Support for implicit deferred triggers and better diagnostics for triggers#51922crisbeto wants to merge 2 commits intoangular:mainfrom
crisbeto wants to merge 2 commits intoangular:mainfrom
Conversation
If a trigger element can't be accessed from the defer block, we don't generate any instructions for it. These changes add a diagnostic that will surface the error to users.
Adds support for defining `viewport`, `interaction` and `hover` triggers with no parameters. If the framework encounters such a case, it resolves the trigger to the root element of the `@placeholder` block. Triggers with no parameters have the following restrictions: 1. They have to be placed on an `@defer` block that has an `@placeholder`. 2. The `@placeholder` can only have one root node. 3. The root placeholder node has to be an element.
0f7d74f to
7378f3d
Compare
jessicajaniuk
approved these changes
Sep 27, 2023
| // If the trigger doesn't have a reference, it is inferred as the root element node of the | ||
| // placeholder, if it only has one root node. Otherwise it's ambiguous so we don't | ||
| // attempt to resolve further. | ||
| return children !== null && children.length === 1 && children[0] instanceof Element ? |
Contributor
There was a problem hiding this comment.
Why not just apply the trigger to every root node rather than require one?
Member
Author
There was a problem hiding this comment.
What we'd talked about was that if there are multiple root nodes, it could lead to some weird situations like a closing icon positioned at the top of the container causing the entire thing to load. Binding to each root node can also be a problem for the interaction and hover triggers, because there could be text nodes in-between that won't fire any events.
atscott
approved these changes
Sep 27, 2023
atscott
approved these changes
Sep 27, 2023
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit e2e3d69. |
dylhunn
pushed a commit
that referenced
this pull request
Sep 27, 2023
Adds support for defining `viewport`, `interaction` and `hover` triggers with no parameters. If the framework encounters such a case, it resolves the trigger to the root element of the `@placeholder` block. Triggers with no parameters have the following restrictions: 1. They have to be placed on an `@defer` block that has an `@placeholder`. 2. The `@placeholder` can only have one root node. 3. The root placeholder node has to be an element. PR Close #51922
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…lar#51922) If a trigger element can't be accessed from the defer block, we don't generate any instructions for it. These changes add a diagnostic that will surface the error to users. PR Close angular#51922
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…#51922) Adds support for defining `viewport`, `interaction` and `hover` triggers with no parameters. If the framework encounters such a case, it resolves the trigger to the root element of the `@placeholder` block. Triggers with no parameters have the following restrictions: 1. They have to be placed on an `@defer` block that has an `@placeholder`. 2. The `@placeholder` can only have one root node. 3. The root placeholder node has to be an element. PR Close angular#51922
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
viewport,hoverandinteractiondeferred triggers with an implicit element reference, as well as a diagnostic for the case where the deferred block can't resolve its trigger element. Split up into the following commits:fix(compiler): add diagnostic for inaccessible deferred trigger
If a trigger element can't be accessed from the defer block, we don't generate any instructions for it. These changes add a diagnostic that will surface the error to users.
feat(core): support deferred triggers with implicit triggers
Adds support for defining
viewport,interactionandhovertriggers with no parameters. If the framework encounters such a case, it resolves the trigger to the root element of the@placeholderblock. Triggers with no parameters have the following restrictions:@deferblock that has an@placeholder.@placeholdercan only have one root node.