Skip to content

refactor: relocate animation renderer class for private exports#51910

Closed
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:private-export
Closed

refactor: relocate animation renderer class for private exports#51910
jessicajaniuk wants to merge 1 commit intoangular:mainfrom
jessicajaniuk:private-export

Conversation

@jessicajaniuk
Copy link
Copy Markdown
Contributor

This is a pre-emptive move of the animation renderer to prepare for #50738 to land safely.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@jessicajaniuk jessicajaniuk added area: animations legacy animations package only. Otherwise use area: core. action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 26, 2023
@ngbot ngbot bot added this to the Backlog milestone Sep 26, 2023
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this is a pre-emptive move of the animation renderer to prepare for angular#50738 to land safely.
@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit labels Sep 26, 2023
@dylhunn
Copy link
Copy Markdown
Contributor

dylhunn commented Sep 26, 2023

This PR was merged into the repository by commit ac1afd8.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2023
@jessicajaniuk jessicajaniuk deleted the private-export branch November 9, 2023 20:35
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…lar#51910)

this is a pre-emptive move of the animation renderer to prepare for angular#50738 to land safely.

PR Close angular#51910
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: animations legacy animations package only. Otherwise use area: core. target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants