Use TaskType keys for counting tasks instead of hardcoding the key values #51739
Conversation
JiaLiPassion
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the PR.
|
Closing as this PR is stale and we're looking to reduce the number of open PR. Thank you for your understanding. |
|
Maybe it would have been easier to close it 1 year ago by merging it. It was already approved by then. Have a great day! |
|
If you'd like the rebase it, we can re-open the PR. It was probably forgotten to add it to the merge queue. Because of the synchronization between github and Google's monorepo the merge is less trivial than usual. |
|
Hello! Sorry for the delay. I have rebased the change now as you asked me. |
|
Hey @JeanMeche can you take a look over this PR, please? |
|
We need you to sign the CLA for the PR to go foward. Thank you. |
|
I have signed the CLA. |
…ure that can have keys named as the values of the `TaskType` type. The Closure Compiler used at Google has a property renaming optimization that can change the property names when minifying code. Having the correct type helps the TSJS team that develops a tool to identfy property renaming issues directly in TypeScript. Signed-off-by: Costin Sin <sin.costinrobert@gmail.com>
…ure that can have keys (#51739) named as the values of the `TaskType` type. The Closure Compiler used at Google has a property renaming optimization that can change the property names when minifying code. Having the correct type helps the TSJS team that develops a tool to identfy property renaming issues directly in TypeScript. Signed-off-by: Costin Sin <sin.costinrobert@gmail.com> PR Close #51739
…ure that can have keys (#51739) named as the values of the `TaskType` type. The Closure Compiler used at Google has a property renaming optimization that can change the property names when minifying code. Having the correct type helps the TSJS team that develops a tool to identfy property renaming issues directly in TypeScript. Signed-off-by: Costin Sin <sin.costinrobert@gmail.com> PR Close #51739
|
This PR was merged into the repository by commit 2e54d6d. The changes were merged into the following branches: main, 18.2.x, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Change the type of
_taskCountsto an IndexSignature that can have keys named as the values of theTaskTypetype.The Closure Compiler used at Google has a property renaming optimization that can change the property names when minifying code. Having the correct type helps the TSJS team that develops a tool to identfy property renaming issues directly in TypeScript.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
The program behavior did not change.
Does this PR introduce a breaking change?