feat(compiler): extract docs info for enums, pipes, and NgModules#51733
Closed
jelbourn wants to merge 7 commits intoangular:mainfrom
Closed
feat(compiler): extract docs info for enums, pipes, and NgModules#51733jelbourn wants to merge 7 commits intoangular:mainfrom
jelbourn wants to merge 7 commits intoangular:mainfrom
Conversation
atscott
approved these changes
Sep 12, 2023
a94175d to
17c7abe
Compare
This commit adds a barebones skeleton for extracting information to be used for extracting info that can be used for API reference generation. Subsequent PRs will expand on this with increasingly real extraction. I started with @alxhub's angular#51615 and very slightly polished to get to this minimal commit.
Based on top of angular#51682 This expands on the skeleton previously added to extract docs info for classes, including properties, methods, and method parameters. Type information and Angular-specific info (e.g. inputs) will come in future PRs.
Based on top of angular#51685 This expands on the extraction with information for directives, including inputs and outputs. As part of this change, I've refactored the extraction code related to class and to directives into their own extractor classes to more cleanly separate extraction logic based on type of statement.
Based on top of angular#51697 Adds extraction for accessors (getters/setters), rest params, and resolved type info for everything so far. This also refactors function extraction into a new class and splits tests for common class info and directive info into separate files.
Based on top of #angular#51700 Also updates extraction to ignore un-exported statements.
Based on top of angular#51713 This commit adds docs extraction for information provided in JsDoc comments, including descriptions and Jsdoc tags.
Based on top of angular#51717 This commit adds extraction for enums, pipes, and NgModules. It also adds a couple of tests for JsDoc extraction that weren't covered in the previous commit.
17c7abe to
bc9d32f
Compare
Contributor
Author
|
Caretaker note: the Windows CI failure is a flake unrelated to this change. This PR includes the changes from all of #51682, #51685, #51697, #51700, #51713, and #51717 all of which have been reviewed and approved. I can't currently run an internal presubmit for this because my workstation is off network; I would much appreciate if you could run a presubmit for me! (it should not remotely affect Google internal targets) |
Member
|
This PR was merged into the repository by commit 2e41488. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 18, 2023
Based on top of #51685 This expands on the extraction with information for directives, including inputs and outputs. As part of this change, I've refactored the extraction code related to class and to directives into their own extractor classes to more cleanly separate extraction logic based on type of statement. PR Close #51733
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 18, 2023
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 18, 2023
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Sep 18, 2023
This was referenced Sep 18, 2023
This was referenced Sep 18, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit adds a barebones skeleton for extracting information to be used for extracting info that can be used for API reference generation. Subsequent PRs will expand on this with increasingly real extraction. I started with @alxhub's angular#51615 and very slightly polished to get to this minimal commit. PR Close angular#51733
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Based on top of angular#51682 This expands on the skeleton previously added to extract docs info for classes, including properties, methods, and method parameters. Type information and Angular-specific info (e.g. inputs) will come in future PRs. PR Close angular#51733
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Based on top of angular#51685 This expands on the extraction with information for directives, including inputs and outputs. As part of this change, I've refactored the extraction code related to class and to directives into their own extractor classes to more cleanly separate extraction logic based on type of statement. PR Close angular#51733
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ngular#51733) Based on top of angular#51697 Adds extraction for accessors (getters/setters), rest params, and resolved type info for everything so far. This also refactors function extraction into a new class and splits tests for common class info and directive info into separate files. PR Close angular#51733
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…lar#51733) Based on top of #angular#51700 Also updates extraction to ignore un-exported statements. PR Close angular#51733
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Based on top of angular#51713 This commit adds docs extraction for information provided in JsDoc comments, including descriptions and Jsdoc tags. PR Close angular#51733
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…gular#51733) Based on top of angular#51717 This commit adds extraction for enums, pipes, and NgModules. It also adds a couple of tests for JsDoc extraction that weren't covered in the previous commit. PR Close angular#51733
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on top of #51717
This commit adds extraction for enums, pipes, and NgModules. It also adds a couple of tests for JsDoc extraction that weren't covered in the previous commit.