refactor(compiler): generate arrow functions for setClassMetadata calls#51637
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler): generate arrow functions for setClassMetadata calls#51637crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
commented
Sep 3, 2023
packages/compiler-cli/src/ngtsc/annotations/common/test/metadata_spec.ts
Outdated
Show resolved
Hide resolved
af228eb to
11eb7e2
Compare
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Sep 4, 2023
Updates the logic for removing Angular metadata and pure top-level functions to account for arrow-function-based IIFEs. Currently Angular doesn't generate arrow functions, but it's being explored in angular/angular#51637.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Sep 4, 2023
Updates the logic for removing Angular JIT calls to account for arrow-function-based IIFEs. Currently Angular doesn't generate arrow functions, but it's being explored in angular/angular#51637.
Member
Author
|
The file size regressions here are legit. I've sent out angular/angular-cli#25776 to update the CLI to account for IIFEs using arrow functions. |
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Sep 4, 2023
Updates the logic for removing Angular metadata and pure top-level functions to account for arrow-function-based IIFEs. Currently Angular doesn't generate arrow functions, but it's being explored in angular/angular#51637.
crisbeto
added a commit
to crisbeto/angular-cli
that referenced
this pull request
Sep 4, 2023
Updates the logic for removing Angular JIT calls to account for arrow-function-based IIFEs. Currently Angular doesn't generate arrow functions, but it's being explored in angular/angular#51637.
dgp1130
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 5, 2023
Updates the logic for removing Angular metadata and pure top-level functions to account for arrow-function-based IIFEs. Currently Angular doesn't generate arrow functions, but it's being explored in angular/angular#51637.
dgp1130
pushed a commit
to angular/angular-cli
that referenced
this pull request
Sep 5, 2023
Updates the logic for removing Angular JIT calls to account for arrow-function-based IIFEs. Currently Angular doesn't generate arrow functions, but it's being explored in angular/angular#51637.
Reworks the `setClassMetadata` calls to generate arrow functions instead of full anonymous function declarations. While this won't have an effect on production bundle sizes, it's easier to read and it should lead to small parsing time gains in dev mode.
11eb7e2 to
e9a3546
Compare
Member
Author
|
Looks like the changes from angular/angular-cli#25776 did the trick. Marking as ready to review. |
devversion
approved these changes
Sep 21, 2023
Member
Author
|
I want to TGP this one just in case. |
Member
Author
|
Passing TGP (except for one unrelated broken target) |
Contributor
|
This PR was merged into the repository by commit d6bfebe. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ls (angular#51637) Reworks the `setClassMetadata` calls to generate arrow functions instead of full anonymous function declarations. While this won't have an effect on production bundle sizes, it's easier to read and it should lead to small parsing time gains in dev mode. PR Close angular#51637
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the
setClassMetadatacalls to generate arrow functions instead of full anonymous function declarations. While this won't have an effect on production bundle sizes, it's easier to read and it should lead to small parsing time gains in dev mode.