fix(router): Remove urlHandlingStrategy from public Router properties#51631
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(router): Remove urlHandlingStrategy from public Router properties#51631atscott wants to merge 1 commit intoangular:mainfrom
urlHandlingStrategy from public Router properties#51631atscott wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
Author
|
note: blocked by 2 remaining uses in g3 (cl/560104673, cl/560104678) |
This commit removes the `urlHandlingStrategy` from the public Router's API BREAKING CHANGE: `urlHandlingStrategy` has been removed from the Router public API. This should instead be configured through the provideRouter or RouterModule.forRoot APIs.
e47bdf1 to
16723ba
Compare
AndrewKushnir
approved these changes
Sep 1, 2023
AndrewKushnir
approved these changes
Sep 1, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
hexiaokang
approved these changes
Sep 3, 2023
Contributor
Author
|
caretaker note: cl/560104678 is not submitted but every reviewer has removed themselves from the change. Please merge this PR and refer to that CL if anyone reaches out to you due to the breakage. |
jessicajaniuk
approved these changes
Sep 5, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Member
|
This PR was merged into the repository by commit b2aff43. |
Contributor
|
Looks like this caused several G3 issues and needs to be reverted for now. |
jessicajaniuk
pushed a commit
to jessicajaniuk/angular
that referenced
this pull request
Sep 6, 2023
…properties (angular#51631)" This reverts commit b2aff43.
Contributor
|
We were able to resolve the G3 issues. Closing again. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…es (angular#51631) This commit removes the `urlHandlingStrategy` from the public Router's API BREAKING CHANGE: `urlHandlingStrategy` has been removed from the Router public API. This should instead be configured through the provideRouter or RouterModule.forRoot APIs. PR Close angular#51631
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
urlHandlingStrategyfrom the public Router's APIBREAKING CHANGE:
urlHandlingStrategyhas been removed from the Router public API. This should instead be configured through the provideRouter or RouterModule.forRoot APIs.