Skip to content

docs: Update common routing tasks guide to use standalone#51558

Closed
atscott wants to merge 2 commits intoangular:mainfrom
atscott:routingmdstandalone
Closed

docs: Update common routing tasks guide to use standalone#51558
atscott wants to merge 2 commits intoangular:mainfrom
atscott:routingmdstandalone

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Aug 29, 2023

Update the common routing tasks guide to use standalone features.

@atscott atscott added area: docs area: router target: major This PR is targeted for the next major release labels Aug 29, 2023
@ngbot ngbot bot added this to the Backlog milestone Aug 29, 2023
@atscott atscott force-pushed the routingmdstandalone branch 5 times, most recently from 8db10a4 to 3bf3892 Compare August 29, 2023 20:19
@pullapprove pullapprove bot requested a review from dgp1130 August 29, 2023 20:19
@MarkTechson MarkTechson self-requested a review August 29, 2023 22:12
@atscott atscott force-pushed the routingmdstandalone branch from 3bf3892 to adbfd24 Compare August 30, 2023 16:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 30, 2023

Deployed aio for 2e12bdf to: https://ng-dev-previews-fw--pr-angular-angular-51558-wm8rfnks.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link
Copy Markdown
Contributor

@MarkTechson MarkTechson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Sep 8, 2023
@ngbot
Copy link
Copy Markdown

ngbot bot commented Sep 8, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: setup" is failing
    pending status "pullapprove" is pending
    pending missing required status "ci/circleci: build"
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

devversion and others added 2 commits September 8, 2023 14:16
…ge (angular#51500)

The localize package intentionally duplicates some logic from the
compiler to avoid adding a dependency. This is now an error in the
packaging rule to prevent common pitfalls/code duplication. Here it's
an explicit decision though so we mark it as such and ask for the check
to be ignored for the particular import.

PR Close angular#51500
@atscott atscott force-pushed the routingmdstandalone branch from 4fedee5 to 2e12bdf Compare September 8, 2023 21:16
@AndrewKushnir AndrewKushnir removed the request for review from dgp1130 September 8, 2023 21:23
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository by commit 05762b9.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 9, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…ge (angular#51500) (angular#51558)

The localize package intentionally duplicates some logic from the
compiler to avoid adding a dependency. This is now an error in the
packaging rule to prevent common pitfalls/code duplication. Here it's
an explicit decision though so we mark it as such and ask for the check
to be ignored for the particular import.

PR Close angular#51500

PR Close angular#51558
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants