fix(core): run afterRender callbacks outside of the Angular zone#51551
Closed
devknoll wants to merge 1 commit intoangular:16.2.xfrom
Closed
fix(core): run afterRender callbacks outside of the Angular zone#51551devknoll wants to merge 1 commit intoangular:16.2.xfrom
devknoll wants to merge 1 commit intoangular:16.2.xfrom
Conversation
afterRender should run outside of the Angular zone so that it does not trigger further CD cycles
ea01dd4 to
7185780
Compare
Contributor
Author
jessicajaniuk
approved these changes
Aug 29, 2023
Contributor
|
This PR was merged into the repository by commit 0c7c852. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Aug 29, 2023
) afterRender should run outside of the Angular zone so that it does not trigger further CD cycles PR Close #51551
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
afterRender should run outside of the Angular zone so that it does not trigger further CD cycles
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Callbacks are executed in the Angular zone, causing patched APIs like
setTimeoutto trigger subsequent change detection cycles, and furtherafterRendercallbacks.Issue Number: #51343
What is the new behavior?
Callbacks are always executed outside of the Angular zone, preventing accidental infinite render loops.
Does this PR introduce a breaking change?
afterRenderis in developer preview, and so this is not considered a breaking change.Other information
Closes #51343