fix(common): allow to specify only some properties of DatePipeConfig#51287
Closed
PowerKiKi wants to merge 1 commit intoangular:mainfrom
Closed
fix(common): allow to specify only some properties of DatePipeConfig#51287PowerKiKi wants to merge 1 commit intoangular:mainfrom
DatePipeConfig#51287PowerKiKi wants to merge 1 commit intoangular:mainfrom
Conversation
The code already supports `DatePipeConfig` to have only some properties set, and not all. But the typing disallows it. This aligns the typing with the code.
089a7c0 to
2f8d4e3
Compare
Contributor
Author
|
Should we consider this a breaking change because it could produce new TS errors (i.e. |
Contributor
Contributor
|
The TGP is green. |
jessicajaniuk
approved these changes
Oct 6, 2023
AndrewKushnir
approved these changes
Oct 6, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
|
This PR was merged into the repository by commit 85843e8. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
angular#51287) The code already supports `DatePipeConfig` to have only some properties set, and not all. But the typing disallows it. This aligns the typing with the code. PR Close angular#51287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The code already supports
DatePipeConfigto have only some properties set, and not all. But the typing disallows it. This aligns the typing with the code.Issue Number: N/A
What is the new behavior?
Can specify only some properties of
DatePipeConfigDoes this PR introduce a breaking change?
Other information