Ivy AST for deferred blocks by crisbeto · Pull Request #51050 · angular/angular

crisbeto · 2023-07-15T09:23:31Z

⚠️Disclaimer⚠️ this PR implements syntax that is still in an open RFC. It will be adjusted once the RFC is closed.

Adds the logic to create defer-specific AST nodes from the generic HTML BlockGroup and Block.

Split across a couple of commits to make it easier to review.

crisbeto · 2023-07-15T09:56:26Z

packages/compiler/src/render3/r3_ast.ts

I'll likely send a follow-up PR to refactor the triggers into a map since they aren't allowed to repeat, but for now this should be enough to unblock any further work.

AndrewKushnir

@crisbeto looks great 👍

packages/compiler/src/render3/r3_deferred_blocks.ts

packages/compiler/src/render3/r3_template_transform.ts

crisbeto

Thank you for the review @AndrewKushnir, I've addressed all of the feedback.

packages/compiler/src/render3/r3_deferred_blocks.ts

packages/compiler/src/render3/r3_template_transform.ts

AndrewKushnir

👍

packages/compiler/src/render3/r3_deferred_triggers.ts

Adds the logic to create `defer`-specific AST nodes from the generic HTML `BlockGroup` and `Block`. The logic for parsing the triggers will be in the next commit.

Adds the logic to parse the `when` and `on` triggers in a deferred block.

jessicajaniuk

This looks fantastic! 🍪

jessicajaniuk · 2023-07-17T19:36:05Z

packages/compiler/src/render3/r3_deferred_blocks.ts

insert highlander joke here

jessicajaniuk · 2023-07-17T19:36:36Z

packages/compiler/src/render3/r3_deferred_blocks.ts

I would make another highlander joke, but there can be only one.

crisbeto · 2023-07-17T20:41:02Z

Caretaker note: there's a pending language service review, but the changes there are trivial.

jessicajaniuk · 2023-07-17T21:05:52Z

This PR was merged into the repository by commit 76d22ae.

Adds the logic to parse the `when` and `on` triggers in a deferred block. PR Close #51050

Adds the logic to create `defer`-specific AST nodes from the generic HTML `BlockGroup` and `Block`. The logic for parsing the triggers will be in the next commit. PR Close angular#51050

Adds the logic to parse the `when` and `on` triggers in a deferred block. PR Close angular#51050

angular-automatic-lock-bot · 2023-08-17T00:07:59Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Adds the logic to create `defer`-specific AST nodes from the generic HTML `BlockGroup` and `Block`. The logic for parsing the triggers will be in the next commit. PR Close angular#51050

Adds the logic to parse the `when` and `on` triggers in a deferred block. PR Close angular#51050

crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release labels Jul 15, 2023

ngbot bot added this to the Backlog milestone Jul 15, 2023

crisbeto force-pushed the deferred-ivy-ast branch 2 times, most recently from 83a7b78 to 175ecd5 Compare July 15, 2023 09:42

crisbeto commented Jul 15, 2023

View reviewed changes

crisbeto requested a review from AndrewKushnir July 15, 2023 09:57

crisbeto marked this pull request as ready for review July 15, 2023 09:57

pullapprove bot requested a review from alxhub July 15, 2023 09:57

crisbeto force-pushed the deferred-ivy-ast branch from 175ecd5 to a57e371 Compare July 15, 2023 10:00

AndrewKushnir reviewed Jul 17, 2023

View reviewed changes

crisbeto commented Jul 17, 2023

View reviewed changes

packages/compiler/src/render3/r3_deferred_blocks.ts Outdated Show resolved Hide resolved

packages/compiler/src/render3/r3_template_transform.ts Outdated Show resolved Hide resolved

crisbeto force-pushed the deferred-ivy-ast branch from a57e371 to ae4c422 Compare July 17, 2023 07:30

AndrewKushnir approved these changes Jul 17, 2023

View reviewed changes

packages/compiler/src/render3/r3_deferred_triggers.ts Outdated Show resolved Hide resolved

crisbeto force-pushed the deferred-ivy-ast branch from ae4c422 to a3d65e1 Compare July 17, 2023 18:46

AndrewKushnir reviewed Jul 17, 2023

View reviewed changes

packages/compiler/src/render3/r3_deferred_triggers.ts Outdated Show resolved Hide resolved

crisbeto force-pushed the deferred-ivy-ast branch from a3d65e1 to 7f96145 Compare July 17, 2023 19:01

AndrewKushnir approved these changes Jul 17, 2023

View reviewed changes

crisbeto added 2 commits July 17, 2023 23:01

refactor(compiler): introduce deferred block AST

fa2d9bf

Adds the logic to create `defer`-specific AST nodes from the generic HTML `BlockGroup` and `Block`. The logic for parsing the triggers will be in the next commit.

refactor(compiler): add defer trigger parsing

58fa84f

Adds the logic to parse the `when` and `on` triggers in a deferred block.

crisbeto force-pushed the deferred-ivy-ast branch from 7f96145 to 58fa84f Compare July 17, 2023 20:01

jessicajaniuk approved these changes Jul 17, 2023

View reviewed changes

jessicajaniuk closed this in 9e61616 Jul 17, 2023

jessicajaniuk pushed a commit that referenced this pull request Jul 17, 2023

refactor(compiler): add defer trigger parsing (#51050)

76d22ae

Adds the logic to parse the `when` and `on` triggers in a deferred block. PR Close #51050

sunilbaba pushed a commit to sunilbaba/angular that referenced this pull request Jul 26, 2023

refactor(compiler): add defer trigger parsing (angular#51050)

837efeb

Adds the logic to parse the `when` and `on` triggers in a deferred block. PR Close angular#51050

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2023

ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024

refactor(compiler): add defer trigger parsing (angular#51050)

36b84d3

Adds the logic to parse the `when` and `on` triggers in a deferred block. PR Close angular#51050

Conversation

crisbeto commented Jul 15, 2023

Uh oh!

crisbeto Jul 15, 2023

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crisbeto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk Jul 17, 2023

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk Jul 17, 2023

Choose a reason for hiding this comment

Uh oh!

crisbeto commented Jul 17, 2023

Uh oh!

jessicajaniuk commented Jul 17, 2023

Uh oh!

angular-automatic-lock-bot bot commented Aug 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants