Skip to content

fix(core): handle deref returning null on RefactiveNode.#50992

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/safari-deref
Closed

fix(core): handle deref returning null on RefactiveNode.#50992
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/safari-deref

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

On Safari <16.1 there is a bug where deref can return null.

Fixes #50989

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

@JeanMeche JeanMeche marked this pull request as ready for review July 10, 2023 14:57
@pullapprove pullapprove bot requested a review from AndrewKushnir July 10, 2023 14:57
On Safari <16.1 there is a bug where `deref` can return `null`.

Fixes angular#50989
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Jul 11, 2023
@ngbot ngbot bot modified the milestone: Backlog Jul 11, 2023
@pkozlowski-opensource pkozlowski-opensource removed the request for review from AndrewKushnir July 11, 2023 10:50
@dylhunn
Copy link
Copy Markdown
Contributor

dylhunn commented Jul 11, 2023

This PR was merged into the repository by commit 5d6ec03.

dylhunn pushed a commit that referenced this pull request Jul 11, 2023
On Safari <16.1 there is a bug where `deref` can return `null`.

Fixes #50989

PR Close #50992
@dylhunn dylhunn closed this in 5d6ec03 Jul 11, 2023
@JeanMeche JeanMeche deleted the fix/safari-deref branch July 12, 2023 08:06
sunilbaba pushed a commit to sunilbaba/angular that referenced this pull request Jul 26, 2023
…ar#50992)

On Safari <16.1 there is a bug where `deref` can return `null`.

Fixes angular#50989

PR Close angular#50992
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…ar#50992)

On Safari <16.1 there is a bug where `deref` can return `null`.

Fixes angular#50989

PR Close angular#50992
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError null is not an object (evaluating 'd.trackingVersion')

5 participants