fix(http): Run fetch request outside the angular zone#50981
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(http): Run fetch request outside the angular zone#50981JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
9f5b270 to
63d1537
Compare
JeanMeche
commented
Jul 9, 2023
ajafff
reviewed
Jul 10, 2023
ajafff
reviewed
Jul 10, 2023
alan-agius4
reviewed
Jul 10, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche thanks for the fix 👍
alxhub
reviewed
Jul 14, 2023
a13b479 to
b9994b3
Compare
AndrewKushnir
approved these changes
Jul 14, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@JeanMeche looks great, just a quick note to add a comment to document the context. Thank you.
Having the request run in the angular zone has the consequence of triggering the CD for every read of the response stream. This commit wraps the whole `doRequest` to run outside angular with every callback on the observer being called inside the zone. Fixes angular#50979.
AndrewKushnir
approved these changes
Jul 14, 2023
Contributor
Contributor
|
This PR was merged into the repository by commit c5608e5. |
NoelLH
added a commit
to thebiggive/donate-frontend
that referenced
this pull request
Jul 20, 2023
Includes an Angular 16 minor version update fixing an HTTP change detection thing which might impact our resolvers / some page loads' handovers angular/angular#50981
sunilbaba
pushed a commit
to sunilbaba/angular
that referenced
this pull request
Jul 26, 2023
Having the request run in the angular zone has the consequence of triggering the CD for every read of the response stream. This commit wraps the whole `doRequest` to run outside angular with every callback on the observer being called inside the zone. Fixes angular#50979. PR Close angular#50981
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Having the request run in the angular zone has the consequence of triggering the CD for every read of the response stream. This commit wraps the whole `doRequest` to run outside angular with every callback on the observer being called inside the zone. Fixes angular#50979. PR Close angular#50981
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the request run in the angular zone has the consequence of triggering the CD for every read of the response stream.
This commit wraps the whole
doRequestto run outside angular with every callback on the observer being called inside the zone.Fixes #50979.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?