Implement runtime deps tracker #50980

pmvald · 2023-07-09T20:32:44Z

An initial implementation which captures what we need for both JIT and local compilations. This PR only changes deps tracker files which are NOT being used anywhere yet. So this change does not affect anything. In a follow up PR I'll migrate JIT compilation to use this deps tracker (instead of transitiveScopesFor tools and monkey patching) and hopefully it will break lots of tests cross g3 and worldwide which makes it look like I have done something ...

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

packages/core/src/render3/deps_tracker/api.ts

devversion

overall LGTM. this is pretty clean!

packages/core/src/render3/deps_tracker/api.ts

packages/core/src/render3/deps_tracker/deps_tracker.ts

devversion

LGTM overall, just some minor comments

packages/core/src/render3/deps_tracker/deps_tracker.ts

packages/core/test/render3/deps_tracker_spec.ts

devversion · 2023-07-14T12:42:11Z

packages/core/test/render3/deps_tracker_spec.ts

Is the as cast here correct? wouldn't it be NgModuleWIthProvider or something?

The main issue is the import type in NgModuleDef<T> does not include ModuleWithProviders, even though the comment says it should. But changing that would require more changes. In a separate PR I can fix this type issue and make things more consistent.

packages/core/test/render3/deps_tracker_spec.ts

packages/core/src/render3/deps_tracker/deps_tracker.ts

…cy tracker The implementation is more or less follows the pattern in render3/jit/module.ts#transitiveScopesFor helper. A few additional helper functions also added to jit utils.

…untime deps tracker The logic mainly followed the `render3/jit/directive.ts#getStandaloneDefFunctions` helper.

This method mainly has application test beds where we want to apply overrides and re-compute the scope.

… the runtime deps tracker This includes implementation of methods getComponentDependencies and registerNgModule. In order to correlate ng-modules with their declarations it is required to use the method registerNgModule to regiater the ng-module. However, the actual correlation will happen lazily once getComponentDependencies method is called. This lazy behaviour also allows for forward refs to be resolved. The method getComponentDependencies will be used in local compilation mode to compute the rendering component deps in runtime.

The previous commits add a new runtime error code (RUNTIME_DEPS_INVALID_IMPORTED_TYPE) which needs to be added to the golden for the tests to pass.

jessicajaniuk

reviewed-for: public-api

pkozlowski-opensource

LGTM

Reviewed-for: public-api

jessicajaniuk · 2023-07-18T14:04:43Z

This PR was merged into the repository by commit 89c84bf.

…untime deps tracker (#50980) The logic mainly followed the `render3/jit/directive.ts#getStandaloneDefFunctions` helper. PR Close #50980

…#50980) This method mainly has application test beds where we want to apply overrides and re-compute the scope. PR Close #50980

… the runtime deps tracker (#50980) This includes implementation of methods getComponentDependencies and registerNgModule. In order to correlate ng-modules with their declarations it is required to use the method registerNgModule to regiater the ng-module. However, the actual correlation will happen lazily once getComponentDependencies method is called. This lazy behaviour also allows for forward refs to be resolved. The method getComponentDependencies will be used in local compilation mode to compute the rendering component deps in runtime. PR Close #50980

…50980) The previous commits add a new runtime error code (RUNTIME_DEPS_INVALID_IMPORTED_TYPE) which needs to be added to the golden for the tests to pass. PR Close #50980

…cy tracker (angular#50980) The implementation is more or less follows the pattern in render3/jit/module.ts#transitiveScopesFor helper. A few additional helper functions also added to jit utils. PR Close angular#50980

…untime deps tracker (angular#50980) The logic mainly followed the `render3/jit/directive.ts#getStandaloneDefFunctions` helper. PR Close angular#50980

…angular#50980) This method mainly has application test beds where we want to apply overrides and re-compute the scope. PR Close angular#50980

… the runtime deps tracker (angular#50980) This includes implementation of methods getComponentDependencies and registerNgModule. In order to correlate ng-modules with their declarations it is required to use the method registerNgModule to regiater the ng-module. However, the actual correlation will happen lazily once getComponentDependencies method is called. This lazy behaviour also allows for forward refs to be resolved. The method getComponentDependencies will be used in local compilation mode to compute the rendering component deps in runtime. PR Close angular#50980

…ngular#50980) The previous commits add a new runtime error code (RUNTIME_DEPS_INVALID_IMPORTED_TYPE) which needs to be added to the golden for the tests to pass. PR Close angular#50980

angular-automatic-lock-bot · 2023-08-18T00:07:40Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

…cy tracker (angular#50980) The implementation is more or less follows the pattern in render3/jit/module.ts#transitiveScopesFor helper. A few additional helper functions also added to jit utils. PR Close angular#50980

…untime deps tracker (angular#50980) The logic mainly followed the `render3/jit/directive.ts#getStandaloneDefFunctions` helper. PR Close angular#50980

…angular#50980) This method mainly has application test beds where we want to apply overrides and re-compute the scope. PR Close angular#50980

… the runtime deps tracker (angular#50980) This includes implementation of methods getComponentDependencies and registerNgModule. In order to correlate ng-modules with their declarations it is required to use the method registerNgModule to regiater the ng-module. However, the actual correlation will happen lazily once getComponentDependencies method is called. This lazy behaviour also allows for forward refs to be resolved. The method getComponentDependencies will be used in local compilation mode to compute the rendering component deps in runtime. PR Close angular#50980

…ngular#50980) The previous commits add a new runtime error code (RUNTIME_DEPS_INVALID_IMPORTED_TYPE) which needs to be added to the golden for the tests to pass. PR Close angular#50980

pmvald requested a review from devversion July 9, 2023 20:32

pullapprove bot requested a review from crisbeto July 9, 2023 20:32

pmvald added the area: core Issues related to the framework runtime label Jul 9, 2023

ngbot bot added this to the Backlog milestone Jul 9, 2023

pmvald added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 9, 2023

devversion requested a review from alxhub July 11, 2023 14:07

pmvald removed the request for review from crisbeto July 11, 2023 19:29

devversion reviewed Jul 12, 2023

View reviewed changes

packages/core/src/render3/deps_tracker/api.ts Show resolved Hide resolved

devversion approved these changes Jul 13, 2023

View reviewed changes

pmvald force-pushed the rdt-impl branch from a90cd56 to 436a837 Compare July 13, 2023 19:37

pmvald requested a review from devversion July 13, 2023 19:39

pmvald force-pushed the rdt-impl branch from 436a837 to e00e22c Compare July 13, 2023 19:50

devversion approved these changes Jul 14, 2023

View reviewed changes

pmvald force-pushed the rdt-impl branch 2 times, most recently from 848314e to ac6d36d Compare July 17, 2023 00:34

pmvald requested a review from crisbeto July 17, 2023 00:38

pmvald added 4 commits July 17, 2023 12:13

refactor(core): implement getNgModuleScope method of runtime dependen…

03a9575

…cy tracker The implementation is more or less follows the pattern in render3/jit/module.ts#transitiveScopesFor helper. A few additional helper functions also added to jit utils.

refactor(core): implement getStandaloneComponentScope method of the r…

354b1e6

…untime deps tracker The logic mainly followed the `render3/jit/directive.ts#getStandaloneDefFunctions` helper.

refactor(core): implement clearScopeCacheFor for runtime deps tracker

f822feb

This method mainly has application test beds where we want to apply overrides and re-compute the scope.

pmvald force-pushed the rdt-impl branch from ac6d36d to 6c81f9f Compare July 17, 2023 16:13

crisbeto approved these changes Jul 17, 2023

View reviewed changes

test(core): update runtime error list to include deps tracker error

a37d810

The previous commits add a new runtime error code (RUNTIME_DEPS_INVALID_IMPORTED_TYPE) which needs to be added to the golden for the tests to pass.

pullapprove bot requested review from jessicajaniuk and pkozlowski-opensource July 17, 2023 20:45

jessicajaniuk approved these changes Jul 17, 2023

View reviewed changes

pullapprove bot requested a review from dylhunn July 17, 2023 21:55

pkozlowski-opensource approved these changes Jul 18, 2023

View reviewed changes

crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 18, 2023

crisbeto added the target: minor This PR is targeted for the next minor release label Jul 18, 2023

crisbeto removed request for alxhub and dylhunn July 18, 2023 07:34

jessicajaniuk closed this in 48a3197 Jul 18, 2023

jessicajaniuk pushed a commit that referenced this pull request Jul 18, 2023

refactor(core): implement clearScopeCacheFor for runtime deps tracker (…

548cf56

…#50980) This method mainly has application test beds where we want to apply overrides and re-compute the scope. PR Close #50980

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 18, 2023

Implement runtime deps tracker #50980

Implement runtime deps tracker #50980

Uh oh!

Conversation

pmvald commented Jul 9, 2023

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

Uh oh!

devversion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devversion left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

devversion Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

pmvald Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

pkozlowski-opensource left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk commented Jul 18, 2023

Uh oh!

angular-automatic-lock-bot bot commented Aug 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants