build: update angular dev-infra and chromium #50772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d00a269 to
4b9fd33
Compare
Updates Angular dev-infra and Chromium. Fixed up version of angular#50111
838c16f to
67dc610
Compare
Since we updated the devkit dependencies, we need to update the browserslist DB versions in integration tests to avoid browser mismatches causing errors like the following: ``` BrowserslistError: [BABEL] /tmp/ng-integration-test-91jP3g/test-sandbox/node_modules/zone.js/fesm2015/zone.js: Unknown version 114 of edge (While processing: "base$0$0") ```
…ide` We have a lint rule configured that enforces that any abstract member implementation uses an explicit `override` identifier. This ensures that downstream classes will have errors if the parent abstract class suddenly removes the abstract member. The lint rule, living in the dev-infra repository, occasionally does miss some places due to a temporary TS version mismatch that causes syntax kind indices to be different. Looks like we are now matching again and there is a new lint failure that got introduced recently. This commit fixes that error.
67dc610 to
bd4858f
Compare
pkozlowski-opensource
approved these changes
Jun 20, 2023
Member
|
This PR was merged into the repository by commit f77bd0a. |
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 20, 2023
Since we updated the devkit dependencies, we need to update the browserslist DB versions in integration tests to avoid browser mismatches causing errors like the following: ``` BrowserslistError: [BABEL] /tmp/ng-integration-test-91jP3g/test-sandbox/node_modules/zone.js/fesm2015/zone.js: Unknown version 114 of edge (While processing: "base$0$0") ``` PR Close #50772
pkozlowski-opensource
pushed a commit
that referenced
this pull request
Jun 20, 2023
…ide` (#50772) We have a lint rule configured that enforces that any abstract member implementation uses an explicit `override` identifier. This ensures that downstream classes will have errors if the parent abstract class suddenly removes the abstract member. The lint rule, living in the dev-infra repository, occasionally does miss some places due to a temporary TS version mismatch that causes syntax kind indices to be different. Looks like we are now matching again and there is a new lint failure that got introduced recently. This commit fixes that error. PR Close #50772
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Updates Angular dev-infra and Chromium. Fixed up version of angular#50111 PR Close angular#50772
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
Since we updated the devkit dependencies, we need to update the browserslist DB versions in integration tests to avoid browser mismatches causing errors like the following: ``` BrowserslistError: [BABEL] /tmp/ng-integration-test-91jP3g/test-sandbox/node_modules/zone.js/fesm2015/zone.js: Unknown version 114 of edge (While processing: "base$0$0") ``` PR Close angular#50772
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…ide` (angular#50772) We have a lint rule configured that enforces that any abstract member implementation uses an explicit `override` identifier. This ensures that downstream classes will have errors if the parent abstract class suddenly removes the abstract member. The lint rule, living in the dev-infra repository, occasionally does miss some places due to a temporary TS version mismatch that causes syntax kind indices to be different. Looks like we are now matching again and there is a new lint failure that got introduced recently. This commit fixes that error. PR Close angular#50772
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular dev-infra and Chromium. Fixed up version of #50111
Required a couple of fixes in the dev-infra repository, along with identifying angular/angular-cli#25405 in the router unit tests