Skip to content

feat(benchpress): report gc and render time spent in script#50771

Closed
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource:benchpres_new_columns
Closed

feat(benchpress): report gc and render time spent in script#50771
pkozlowski-opensource wants to merge 1 commit intoangular:mainfrom
pkozlowski-opensource:benchpres_new_columns

Conversation

@pkozlowski-opensource
Copy link
Copy Markdown
Member

GC and render events can happen while running scripts as well as outside of the script blocks. The new metric entries capture both the gc and render time happening in the scrip blocks.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jun 19, 2023
GC and render events can happen _while_ running scripts as well as
outside of the script blocks. The new metric entries capture both
the gc and render time happening in the scrip blocks.
@pkozlowski-opensource pkozlowski-opensource added feature Label used to distinguish feature request from other issues area: benchpress target: minor This PR is targeted for the next minor release labels Jun 20, 2023
@ngbot ngbot bot added this to the Backlog milestone Jun 20, 2023
@pkozlowski-opensource pkozlowski-opensource added the action: presubmit The PR is in need of a google3 presubmit label Jun 20, 2023
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review June 20, 2023 14:17
@pullapprove pullapprove bot requested a review from alxhub June 20, 2023 14:17
@pkozlowski-opensource pkozlowski-opensource added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: presubmit The PR is in need of a google3 presubmit labels Jun 20, 2023
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 5, 2023
@atscott
Copy link
Copy Markdown
Contributor

atscott commented Oct 5, 2023

This PR was merged into the repository by commit 2da3551.

@atscott atscott closed this in 2da3551 Oct 5, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
…50771)

GC and render events can happen _while_ running scripts as well as
outside of the script blocks. The new metric entries capture both
the gc and render time happening in the scrip blocks.

PR Close angular#50771
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: benchpress detected: feature PR contains a feature commit feature Label used to distinguish feature request from other issues target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants