Skip to content

fix(http): Send query params on fetch request#50740

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/fetch-params
Closed

fix(http): Send query params on fetch request#50740
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:fix/fetch-params

Conversation

@JeanMeche
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche commented Jun 16, 2023

QueryParams were missing when using the FetchBackend.

Fixes #50728

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

@JeanMeche
fix(http): Send query params on fetch request
6f2e9c7 
QueryParams were missing when using the `FetchBackend`.

Fixes angular#50728
@pullapprove pullapprove bot requested a review from dylhunn June 16, 2023 08:48
@JeanMeche JeanMeche added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: common/http Issues related to HTTP and HTTP Client labels Jun 16, 2023
@ngbot ngbot bot added this to the Backlog milestone Jun 16, 2023
AndrewKushnir
AndrewKushnir approved these changes Jun 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeanMeche looks great, thanks for the fix 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 16, 2023
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn June 16, 2023 22:15
@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Jun 20, 2023

This PR was merged into the repository by commit 135167f.

pkozlowski-opensource pushed a commit that referenced this pull request Jun 20, 2023
@JeanMeche @pkozlowski-opensource
fix(http): Send query params on fetch request (#50740)
9488a3f 
QueryParams were missing when using the `FetchBackend`.

Fixes #50728

PR Close #50740
@JeanMeche JeanMeche deleted the fix/fetch-params branch July 12, 2023 08:08
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Aug 12, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2023
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
@JeanMeche @ChellappanRajan
fix(http): Send query params on fetch request (angular#50740)
0e76f71 
QueryParams were missing when using the `FetchBackend`.

Fixes angular#50728

PR Close angular#50740
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

HttpClient with fetch doesn't handle query params

3 participants

@JeanMeche @pkozlowski-opensource @AndrewKushnir