@dylhunn This looks ready to merge right ?

@JeanMeche Can you do one more rebase on this? I will run the TGP tonight and if it's clean, we can merge it tomorrow for v17. (If not, I'll bump it from the candidate until we can clean up g3.)

@dylhunn Rebase ✅

TGP: https://test.corp.google.com/OCL:572432662:BASE:572432265:1696990907199:c5381c30
Deflake: https://fusion2.corp.google.com/presubmit/572432662/OCL:572432662:BASE:572432265:1696998569066:6270671d/targets
Rerun at HEAD: https://fusion2.corp.google.com/presubmit/572432662/OCL:572432662:BASE:572457695:1697000429516:74e33684/targets

Unfortunately, this breaks a lot of tests, around 10 test suites, each with up to several dozen dotted control names. (Why are people doing this?!)

@JeanMeche, how would you feel about warning, instead of erroring?

Alternatively, you could introduce a boolean flag that controls whether we warn or error, and I can create a patch to warn inside of google3 only, and error externally. To do this, just extract a boolean top-level const (something like warnInsteadOfErrorOnDotControlName) and I can target it with a git patch diff.

Let's keep it simple and hint on this issue with a warning !

caretaker: presubmit is fine. No need for a global, since this is just a warning.

This PR was merged into the repository by commit 43115da.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}