Skip to content

fix(core): typing of TestBed Common token. #49997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(core): typing of TestBed Common token. #49997

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 25, 2023

Both ComponentFixtureAutoDetect and ComponentFixtureNoNgZone are mistyped. Tokens are only instantiated with booleans.

The documentation also only mentions boolean as value !

I mostly see this as a bugfix as the typing is wrong. But is that breaking change acceptable ?

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes (but how breaking) ?

@JeanMeche
fix(core): typing of TestBed Common token.
da2b210 
Both `ComponentFixtureAutoDetect`  and `ComponentFixtureNoNgZone` are mistyped. Tokens are only instantiated with booleans.
@pkozlowski-opensource pkozlowski-opensource added area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 25, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 25, 2023
pkozlowski-opensource
pkozlowski-opensource approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed looks like a bug to me!

Let's see if it lands cleanly in G3 and if so I don't see any particular reason for not including this in v16 as a bug fix (safer to do in v16 where breaking changes are "allowed").

@pkozlowski-opensource pkozlowski-opensource added target: rc This PR is targeted for the next release-candidate and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 25, 2023
pkozlowski-opensource
pkozlowski-opensource approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-testing

@pullapprove pullapprove bot requested a review from jessicajaniuk April 25, 2023 13:51
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Apr 25, 2023

TGP

jessicajaniuk
jessicajaniuk approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core, fw-testing, public-api

@jessicajaniuk jessicajaniuk added the action: global presubmit The PR is in need of a google3 global presubmit label Apr 25, 2023
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Apr 25, 2023

The TGP is green

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit labels Apr 25, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Apr 25, 2023

This PR was merged into the repository by commit 5607e0f.

dylhunn pushed a commit that referenced this pull request Apr 25, 2023
@JeanMeche @dylhunn
fix(core): typing of TestBed Common token. (#49997)
b4531f1 
Both `ComponentFixtureAutoDetect`  and `ComponentFixtureNoNgZone` are mistyped. Tokens are only instantiated with booleans.

PR Close #49997
@dylhunn dylhunn closed this in 5607e0f Apr 25, 2023
@JeanMeche JeanMeche deleted the fix/testbed-tokens branch May 2, 2023 12:06
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 2, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

+1 more reviewer

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

v16-final

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @jessicajaniuk @dylhunn @pkozlowski-opensource