Skip to content

refactor(compiler-cli): Add experimental local compilation mode#49846

Closed
pmvald wants to merge 1 commit intoangular:mainfrom
pmvald:lcm-disable-diags
Closed

refactor(compiler-cli): Add experimental local compilation mode#49846
pmvald wants to merge 1 commit intoangular:mainfrom
pmvald:lcm-disable-diags

Conversation

@pmvald
Copy link
Copy Markdown
Member

@pmvald pmvald commented Apr 14, 2023

In this mode the compiler generates code based on each individual source file without using its dependencies. This mode is suitable only for fast edit/refresh during development.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No change to current behaviour.

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove Bot requested review from alxhub and devversion April 14, 2023 15:34
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Apr 14, 2023
@jessicajaniuk jessicajaniuk added the area: compiler Issues related to `ngc`, Angular's template compiler label Apr 14, 2023
@ngbot ngbot Bot added this to the Backlog milestone Apr 14, 2023
@pmvald pmvald force-pushed the lcm-disable-diags branch 2 times, most recently from e37d59a to 43a8178 Compare April 14, 2023 19:34
@angular-robot angular-robot Bot removed the detected: feature PR contains a feature commit label Apr 14, 2023
@pmvald pmvald force-pushed the lcm-disable-diags branch from 43a8178 to d50d609 Compare April 14, 2023 19:36
@pmvald pmvald changed the title feat(compiler): Add local compilation mode refactor(compiler-cli): Add experimental local compilation mode Apr 14, 2023
Comment thread packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts Outdated
@pmvald pmvald force-pushed the lcm-disable-diags branch 2 times, most recently from 5ddb560 to 41c274f Compare April 14, 2023 23:13
Comment thread packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts Outdated
Comment thread packages/compiler-cli/src/ngtsc/util/src/local_compilation.ts Outdated
Comment thread packages/compiler-cli/src/ngtsc/util/BUILD.bazel Outdated
Copy link
Copy Markdown
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also two commits with identical messages in this PR, which should be squashed into one.

Comment thread packages/compiler-cli/src/ngtsc/core/src/local_compilation.ts Outdated
@pmvald pmvald force-pushed the lcm-disable-diags branch from 96cb0f6 to 621460e Compare April 18, 2023 20:45
@pmvald pmvald requested a review from alxhub April 18, 2023 20:47
Comment thread packages/compiler-cli/src/ngtsc/transform/src/api.ts
In this mode the compiler generates code based on each individual source file without using its dependencies. This mode is suitable only for fast edit/refresh during development.
@pmvald pmvald force-pushed the lcm-disable-diags branch from 621460e to 8b4fa83 Compare April 19, 2023 15:08
@pmvald pmvald requested a review from alxhub April 19, 2023 15:12
@jessicajaniuk jessicajaniuk added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Apr 19, 2023
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove Bot requested a review from dylhunn April 19, 2023 22:53
Copy link
Copy Markdown
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 20, 2023
@jessicajaniuk
Copy link
Copy Markdown
Contributor

Caretaker: win_tests are known flakes. This is safe to merge.

@dylhunn
Copy link
Copy Markdown
Contributor

dylhunn commented Apr 24, 2023

This PR was merged into the repository by commit 345dd6d.

dylhunn pushed a commit that referenced this pull request Apr 24, 2023
)

In this mode the compiler generates code based on each individual source file without using its dependencies. This mode is suitable only for fast edit/refresh during development.

PR Close #49846
@dylhunn dylhunn closed this in 345dd6d Apr 24, 2023
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 25, 2023
@pmvald pmvald deleted the lcm-disable-diags branch May 25, 2023 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants