Skip to content

fix(core): error if document body is null #49818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(core): error if document body is null #49818

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 12, 2023

Fixes an error that came up internally which was being thrown, because in some cases the document.body might be null.

@crisbeto
fix(core): error if document body is null
5e64ae3 
Fixes an error that came up internally which was being thrown, because in some cases the `document.body` might be null.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate labels Apr 12, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 12, 2023
@pullapprove pullapprove bot requested a review from dylhunn April 12, 2023 19:06
@crisbeto crisbeto removed the request for review from dylhunn April 12, 2023 19:15
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2023
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 12, 2023

This PR was merged into the repository by commit 5ac8ca4.

AndrewKushnir pushed a commit that referenced this pull request Apr 12, 2023
@crisbeto @AndrewKushnir
fix(core): error if document body is null (#49818)
4721c48 
Fixes an error that came up internally which was being thrown, because in some cases the `document.body` might be null.

PR Close #49818
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 13, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @AndrewKushnir