Skip to content

ci: disable size tracking CI job in favor of integration tests size checks#49788

Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir:disable_size_check
Closed

ci: disable size tracking CI job in favor of integration tests size checks#49788
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
AndrewKushnir:disable_size_check

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Apr 11, 2023

Currently we have multiple integration apps which are instrumented with the payload size checks. In addition to that, there is a separate CI job that performs similar checks. The checks in CI job are redundant, thus this commit disables a separate CI job.

PR Type

What kind of change does this PR introduce?

  • CI related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
ci: disable size tracking CI job in favor of integration tests size c…
8c4a1c3 
…hecks

Currently we have multiple integration apps which are instrumented with the payload size checks. In addition to that, there is a separate CI job that performs similar checks. The checks in CI job are redundant, thus this commit disables a separate CI job.
@AndrewKushnir AndrewKushnir added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Apr 11, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 11, 2023
@pullapprove pullapprove bot removed request for devversion April 11, 2023 17:36
josephperrott
josephperrott approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 11, 2023
@ngbot
Copy link

ngbot bot commented Apr 11, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    pending status "ci/circleci: test_win" is pending
    pending status "mergeability" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Apr 11, 2023

This PR was merged into the repository by commit cf46dfb.

AndrewKushnir added a commit that referenced this pull request Apr 11, 2023
@AndrewKushnir
ci: disable size tracking CI job in favor of integration tests size c…
d1c83cc 
…hecks (#49788)

Currently we have multiple integration apps which are instrumented with the payload size checks. In addition to that, there is a separate CI job that performs similar checks. The checks in CI job are redundant, thus this commit disables a separate CI job.

PR Close #49788
AndrewKushnir added a commit that referenced this pull request Apr 11, 2023
@AndrewKushnir
ci: disable size tracking CI job in favor of integration tests size c…
687f138 
…hecks (#49788)

Currently we have multiple integration apps which are instrumented with the payload size checks. In addition to that, there is a separate CI job that performs similar checks. The checks in CI job are redundant, thus this commit disables a separate CI job.

PR Close #49788
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 12, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewKushnir @josephperrott @alan-agius4