build: update minimum supported Node version from 16.13.0 -> 16.14.0#49771
build: update minimum supported Node version from 16.13.0 -> 16.14.0#49771AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
0bd5abf to
49001d4
Compare
|
Aren't you missing the change in |
This commit updates the minimum supported Node version across packages from 16.13.0 -> 16.14.0 to ensure compatibility with dependencies.
49001d4 to
9ade052
Compare
| "license": "MIT", | ||
| "engines": { | ||
| "node": "^16.13.0 || >=18.10.0" | ||
| "node": "^16.14.0 || >=18.10.0" |
There was a problem hiding this comment.
Is it necessary for us to bump this version since our users don't have to rely on the package we are seeing issue with?
I am happy to have us bump to a later node version if we want, but I don't know that its strictly necessary for our own issue we are seeing.
cc: @alxhub
There was a problem hiding this comment.
I've seen that lru-cache 9.0.0 is pulled by @angular-devkit/build-angular with a project on next and v15. But I couldn't trigger that error. Any idea which functionality triggers it ?
There was a problem hiding this comment.
@josephperrott , lru-cache cache is a widely used package and is used by a number of our deps (CLI) and is a matter of time until one of our transitive dependencies consumes it. Hence, to keep the node versions in sync with the CLI, I suggest to bump it.
Hence, it would be best to bump since bumping to 16.14.0 might be too distributive in a minor/patch version.
There was a problem hiding this comment.
lru-cache ends up being downloaded as a dependency when you install @angular-devkit/build-angular, and if you are running a lower version of node (i.e. 16.13.0) it fails the engines check during install.
nvm install 16.13.0;
npx @angular/cli new test_project
You will see the unsupported engine message on install attempt
There was a problem hiding this comment.
Makes sense for me to do in v16-next
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit b98ecbc. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit updates the minimum supported Node version across packages from 16.13.0 -> 16.14.0 to ensure compatibility with dependencies.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?