Skip to content

refactor(core): remove unnecessary reflect-metadata import.#49673

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:chore/remove-reflect-jit-test
Closed

refactor(core): remove unnecessary reflect-metadata import.#49673
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:chore/remove-reflect-jit-test

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 2, 2023

Looks like this import in the JIT unit tests was unnecessary ! Let's remove it.

The import is not needed for the tests to run.
@JeanMeche JeanMeche force-pushed the chore/remove-reflect-jit-test branch from 3cc7f17 to d9bf4f3 Compare April 2, 2023 22:02
@JeanMeche JeanMeche marked this pull request as ready for review April 2, 2023 22:16
@pullapprove pullapprove bot requested a review from AndrewKushnir April 2, 2023 22:16
@alan-agius4 alan-agius4 added core: di area: testing Issues related to Angular testing features, such as TestBed action: review The PR is still awaiting reviews from at least one requested reviewer and removed core: di labels Apr 3, 2023
@ngbot ngbot bot modified the milestone: Backlog Apr 3, 2023
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 3, 2023
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2023
@dylhunn
Copy link
Contributor

dylhunn commented Apr 4, 2023

This PR was merged into the repository by commit 719f6a0.

@dylhunn dylhunn closed this in 719f6a0 Apr 4, 2023
dylhunn pushed a commit that referenced this pull request Apr 4, 2023
The import is not needed for the tests to run.

PR Close #49673
@JeanMeche JeanMeche deleted the chore/remove-reflect-jit-test branch April 4, 2023 06:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: testing Issues related to Angular testing features, such as TestBed target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants