Skip to content

docs: fix typo#49669

Closed
slimache wants to merge 1 commit intoangular:mainfrom
slimache:fix-fake-async-typo
Closed

docs: fix typo#49669
slimache wants to merge 1 commit intoangular:mainfrom
slimache:fix-fake-async-typo

Conversation

@slimache
Copy link
Contributor

@slimache slimache commented Apr 1, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott April 1, 2023 21:11
@ngbot ngbot bot added this to the Backlog milestone Apr 1, 2023
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 3, 2023
@ngbot
Copy link

ngbot bot commented Apr 3, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Apr 3, 2023
@atscott
Copy link
Contributor

atscott commented Apr 3, 2023

caretaker: docs only. No need to run internal tests

@dylhunn
Copy link
Contributor

dylhunn commented Apr 4, 2023

This PR was merged into the repository by commit c912294.

@dylhunn dylhunn closed this in c912294 Apr 4, 2023
dylhunn pushed a commit that referenced this pull request Apr 4, 2023
@slimache @dylhunn
docs: fix typo (#49669)
bd82fbe 
PR Close #49669
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 5, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@slimache @atscott @dylhunn