Skip to content

docs: Update Popup.service example to remove ComponentFactoryResolver#49638

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/cfr
Closed

docs: Update Popup.service example to remove ComponentFactoryResolver#49638
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/cfr

Conversation

@JeanMeche
Copy link
Member

ComponentFactoryResolver has been deprecated and can be replaced by createComponent().

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

`ComponentFactoryResolver` has been deprecated and can be replaced by `createComponent()`.
@ngbot ngbot bot added this to the Backlog milestone Mar 29, 2023
@AndrewKushnir AndrewKushnir requested review from AndrewKushnir and removed request for pkozlowski-opensource March 29, 2023 21:26
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 29, 2023
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @JeanMeche 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 29, 2023
@atscott
Copy link
Contributor

atscott commented Mar 30, 2023

This PR was merged into the repository by commit d596ec0.

@atscott atscott closed this in d596ec0 Mar 30, 2023
atscott pushed a commit that referenced this pull request Mar 30, 2023
…r` (#49638)

`ComponentFactoryResolver` has been deprecated and can be replaced by `createComponent()`.

PR Close #49638
@JeanMeche JeanMeche deleted the docs/cfr branch April 15, 2023 19:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants