feat(core): support Provider type in Injector.create #49587
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
dylhunn
approved these changes
Mar 27, 2023
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, public-api
jessicajaniuk
approved these changes
Mar 27, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: fw-core, public-api
alxhub
approved these changes
Jun 12, 2023
This commit updates the Injector.create function to accept the `Provider` type in addition to the `StaticProvider` type. This should make it easier to work with the Injector.create function and have less type casts if you have a list of `Provider`s available.
124ec63 to
72ab3de
Compare
Contributor
Author
Contributor
Author
|
Caretaker note: global presubmit is "green", this PR is ready for merge. |
Member
|
This PR was merged into the repository by commit cdaa2a8. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
This commit updates the Injector.create function to accept the `Provider` type in addition to the `StaticProvider` type. This should make it easier to work with the Injector.create function and have less type casts if you have a list of `Provider`s available. PR Close angular#49587
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Injector.create function to accept the
Providertype in addition to theStaticProvidertype. This should make it easier to work with the Injector.create function and have less type casts if you have a list ofProviders available.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?