Skip to content

Revert "fix(migrations): preserve trailing commas in code generated by standalone migration (#49533)"#49547

Closed
crisbeto wants to merge 1 commit intoangular:15.2.xfrom
crisbeto:15.2.x-revert-trailing-comma
Closed

Revert "fix(migrations): preserve trailing commas in code generated by standalone migration (#49533)"#49547
crisbeto wants to merge 1 commit intoangular:15.2.xfrom
crisbeto:15.2.x-revert-trailing-comma

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 22, 2023

This reverts commit bf4d856.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: migrations Issues related to `ng update`/`ng generate` migrations labels Mar 22, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 22, 2023
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 22, 2023
@crisbeto crisbeto added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 22, 2023
@crisbeto
Copy link
Member Author

crisbeto commented Mar 22, 2023

Caretaker note: we only want to revert this fix from 15.2.0. We should keep it in main.

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 22, 2023
@atscott
Copy link
Contributor

atscott commented Mar 22, 2023

This PR was merged into the repository by commit 288156b.

@atscott atscott closed this Mar 22, 2023
atscott pushed a commit that referenced this pull request Mar 22, 2023
@crisbeto @atscott
Revert "fix(migrations): preserve trailing commas in code generated b…
288156b 
…y standalone migration (#49533)" (#49547)

This reverts commit bf4d856.

PR Close #49547
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 22, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott Awaiting requested review from atscott

@pkozlowski-opensource pkozlowski-opensource Awaiting requested review from pkozlowski-opensource

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: migrations Issues related to `ng update`/`ng generate` migrations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @atscott