Revert "fix(platform-server): insert transfer state script before other script tags (#48868)"#49112
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
Revert "fix(platform-server): insert transfer state script before other script tags (#48868)"#49112alan-agius4 wants to merge 1 commit intoangular:mainfrom
script before other script tags (#48868)"#49112alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
approved these changes
Feb 16, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@alan-agius4 LGTM 👍
One quick note: could you please add a comment into the code to describe that the way we insert the script tag (for transfer state) is intentional due to the fact that the type=module script are deferred by default (as you mentioned in the PR description).
…ther `script` tags (angular#48868)" This reverts commit 2fc5b70 as this change is no longer needed since `type=module` script are deferred by default. Which causes the transfer data to be queried after the browser has finished parsing the DOM.
8961a79 to
b5913d5
Compare
Contributor
|
This PR was merged into the repository by commit 2d51b5f. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2fc5b70 as this change is no longer needed since
type=modulescript are deferred by default. Which causes the transfer data to be queried after the browser has finished parsing the DOM.