Skip to content

docs: Improve previous version navigation#49063

Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/version-navigation
Closed

docs: Improve previous version navigation#49063
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:docs/version-navigation

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Feb 14, 2023

In archive mode the link to the current doc will point to same page. If the page doesn't exist anymore, it will show a contextualized warning message.

See #46850

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

This PR was previously at #48965

@pullapprove pullapprove bot requested a review from josephperrott February 14, 2023 20:51
@JeanMeche JeanMeche mentioned this pull request Feb 14, 2023
Closed
1 task
@ngbot ngbot bot added this to the Backlog milestone Feb 14, 2023
@JeanMeche JeanMeche force-pushed the docs/version-navigation branch from 503aa0f to dfbec21 Compare February 14, 2023 21:00
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 6, 2023
josephperrott
josephperrott approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @mgechev will need to decide if we want to do it.

@josephperrott josephperrott requested a review from mgechev March 6, 2023 18:24
@pullapprove pullapprove bot requested review from dylhunn and jessicajaniuk March 6, 2023 18:24
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Mar 13, 2023

@JeanMeche Looks like this needs a rebase

jessicajaniuk
jessicajaniuk approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the need for a rebase, this looks good. Once you rebase, I'll approve for the size-tracking changes.

@pullapprove pullapprove bot requested a review from jessicajaniuk March 13, 2023 17:47
@JeanMeche JeanMeche force-pushed the docs/version-navigation branch 2 times, most recently from 8fea005 to 9e9bde0 Compare March 13, 2023 18:04
@jessicajaniuk jessicajaniuk added the target: patch This PR is targeted for the next patch release label Mar 13, 2023
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Mar 13, 2023

@JeanMeche Looks like AIO payloads have changed since the pre-rebase run.

@JeanMeche JeanMeche force-pushed the docs/version-navigation branch from 9e9bde0 to 47223e0 Compare March 13, 2023 19:07
@JeanMeche
Copy link
Member Author

JeanMeche commented Mar 13, 2023

@jessicajaniuk It's OK now, test_win is still flaky

@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Mar 13, 2023

@JeanMeche The test_win issue seems to be affecting everyone. Seems to be an infra issue, and not this PR.

jessicajaniuk
jessicajaniuk approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: docs-infra, size-tracking

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 13, 2023
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Mar 17, 2023
@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 17, 2023

@JeanMeche, can you please fix the conflict?

@JeanMeche
docs: Improve previous version navigation
caae8f7 
In archive mode the link to the current doc will now point to same page.
If the page doesn't exist anymore, it will show a contextualized warning message.

See angular#46850
@JeanMeche JeanMeche force-pushed the docs/version-navigation branch from 47223e0 to caae8f7 Compare March 17, 2023 07:29
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Deployed aio for caae8f7 to: https://ng-dev-previews-fw--pr-angular-angular-49063-t10vc0vi.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Apr 6, 2023

This PR was merged into the repository by commit ed8a595.

AndrewKushnir pushed a commit that referenced this pull request Apr 6, 2023
@JeanMeche @AndrewKushnir
docs: Improve previous version navigation (#49063)
c713d9f 
In archive mode the link to the current doc will now point to same page.
If the page doesn't exist anymore, it will show a contextualized warning message.

See #46850

PR Close #49063
AndrewKushnir pushed a commit that referenced this pull request Apr 6, 2023
@JeanMeche @AndrewKushnir
docs: Improve previous version navigation (#49063)
9c07a42 
In archive mode the link to the current doc will now point to same page.
If the page doesn't exist anymore, it will show a contextualized warning message.

See #46850

PR Close #49063
@JeanMeche JeanMeche deleted the docs/version-navigation branch April 6, 2023 23:52
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 7, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

+2 more reviewers

@hexiaokang hexiaokang hexiaokang approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

8 participants

@JeanMeche @jessicajaniuk @alan-agius4 @AndrewKushnir @josephperrott @hexiaokang @mgechev @dylhunn