fix(compiler-cli): resolve deprecation warning#48812
Closed
JoostK wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): resolve deprecation warning#48812JoostK wants to merge 1 commit intoangular:mainfrom
JoostK wants to merge 1 commit intoangular:mainfrom
Conversation
This commit updates one usage of the `ts.factory.createMethodDeclaration` API to avoid a deprecated function signature, which avoids logging a warning.
crisbeto
reviewed
Jan 23, 2023
| @@ -111,7 +111,6 @@ export function generateInlineTypeCtor( | |||
|
|
|||
| // Create the type constructor method declaration. | |||
| return ts.factory.createMethodDeclaration( | |||
Member
There was a problem hiding this comment.
Do we know when this became deprecated? If it was in 4.8, we would have to support both signatures for a while due to g3.
Member
Author
There was a problem hiding this comment.
Yep, it was deprecated in microsoft/TypeScript#49089 which shipped in 4.8, but the deprecation only started to report a warning in 4.9 (per this line).
The same change was recently made to a different usage of createMethodDeclaration in #48652, so this one should also be fine in g3.
Contributor
|
This PR was merged into the repository by commit 4da1f29. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jan 24, 2023
This commit updates one usage of the `ts.factory.createMethodDeclaration` API to avoid a deprecated function signature, which avoids logging a warning. PR Close #48812
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 27, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.1/15.1.2) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.1/15.1.2) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.1/15.1.2) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.1/15.1.2) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.1/15.1.2) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.1/15.1.2) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.1/15.1.2) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.1` -> `15.1.2`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.1/15.1.2) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.1.2`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1512-2023-01-25) [Compare Source](angular/angular@15.1.1...15.1.2) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [98ccb57117](angular/angular@98ccb57) | fix | handle css selectors with space after an escaped character. ([#​48558](angular/angular#48558)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [145f848a10](angular/angular@145f848) | fix | resolve deprecation warning ([#​48812](angular/angular#48812)) | ##### router | Commit | Type | Description | | -- | -- | -- | | [a6b10f6e59](angular/angular@a6b10f6) | fix | 'createUrlTreeFromSnapshot' with empty paths and named outlets ([#​48734](angular/angular#48734)) | #### Special Thanks Alan Agius, AleksanderBodurri, Andrew Kushnir, Andrew Scott, Charles Lyding, Dylan Hunn, JoostK, Matthieu Riegler, Paul Gschwendtner, Payam Valadkhan, Virginia Dooley, Yann Thomas LE MOIGNE and dario-piotrowicz <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTQuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNC4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1751 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
This commit updates one usage of the `ts.factory.createMethodDeclaration` API to avoid a deprecated function signature, which avoids logging a warning. PR Close angular#48812
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates one usage of the
ts.factory.createMethodDeclarationAPI to avoid a deprecated function signature, which avoids logging a warning.