build: update ng-dev and account for stamping changes#48731
Closed
devversion wants to merge 2 commits intoangular:mainfrom
Closed
build: update ng-dev and account for stamping changes#48731devversion wants to merge 2 commits intoangular:mainfrom
devversion wants to merge 2 commits intoangular:mainfrom
Conversation
Member
devversion
commented
Jan 13, 2023
- updates ng-dev and build-tooling since the previous SHAs are no longer existent after the CircleCI incident snapshot build removal.
- accounts for the new stamping variables.
1dfe165 to
577e2d4
Compare
alan-agius4
approved these changes
Jan 13, 2023
|
Deployed aio for bdd6843 to: https://ng-dev-previews-fw--pr-angular-angular-48731-m4acffuv.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
* updates ng-dev and build-tooling since the previous SHAs are no longer existent after the CircleCI incident snapshot build removal. * accounts for the new stamping variables.
The TSLint rule for ESM/CJS interop was apparently not working for a short period of time due to diverging TypeScript versions. This commit fixes the lint warning to replace the type-only import with a default import. Even thoughn not striclty needed for types- the rule enforces a default import as that is the safer approach for runtime imported symbols. Also the rule is updated to not disallow `cluster` anymore. The types for cluster do no allow for e.g. `cluster.Worker` if cluster refers to the default import. The whole lint rule is not strictly needed anymore since we build & test with ESM in this repo now!
577e2d4 to
bdd6843
Compare
Member
Author
|
Note: skipping pullapprove here as this is all build & bazel related changes where I'm a code owner. |
crisbeto
approved these changes
Jan 13, 2023
Member
Author
|
This PR was merged into the repository by commit 13f10de. |
devversion
added a commit
that referenced
this pull request
Jan 13, 2023
The TSLint rule for ESM/CJS interop was apparently not working for a short period of time due to diverging TypeScript versions. This commit fixes the lint warning to replace the type-only import with a default import. Even thoughn not striclty needed for types- the rule enforces a default import as that is the safer approach for runtime imported symbols. Also the rule is updated to not disallow `cluster` anymore. The types for cluster do no allow for e.g. `cluster.Worker` if cluster refers to the default import. The whole lint rule is not strictly needed anymore since we build & test with ESM in this repo now! PR Close #48731
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
* updates ng-dev and build-tooling since the previous SHAs are no longer existent after the CircleCI incident snapshot build removal. * accounts for the new stamping variables. PR Close angular#48731
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…ar#48731) The TSLint rule for ESM/CJS interop was apparently not working for a short period of time due to diverging TypeScript versions. This commit fixes the lint warning to replace the type-only import with a default import. Even thoughn not striclty needed for types- the rule enforces a default import as that is the safer approach for runtime imported symbols. Also the rule is updated to not disallow `cluster` anymore. The types for cluster do no allow for e.g. `cluster.Worker` if cluster refers to the default import. The whole lint rule is not strictly needed anymore since we build & test with ESM in this repo now! PR Close angular#48731
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.