fix(core): makeEnvironmentProviders should accept EnvironmentProviders#48720
Closed
alxhub wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): makeEnvironmentProviders should accept EnvironmentProviders#48720alxhub wants to merge 1 commit intoangular:mainfrom
alxhub wants to merge 1 commit intoangular:mainfrom
Conversation
`makeEnvironmentProviders` constructs the wrapped `EnvironmentProviders` type, which can only be used in environment injectors (not element injectors). It makes sense that `makeEnvironmentProviders` should be able to accept existing `EnvironmentProviders`-wrapped providers, since it will be providing the same guarantee, but the current types do not allow this. This commit fixes the typings to allow nesting `EnvironmentProviders` and adds a test to verify that it will work.
0e8bca0 to
58838df
Compare
pkozlowski-opensource
approved these changes
Jan 12, 2023
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
AndrewKushnir
approved these changes
Jan 12, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jan 12, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: fw-core, public-api
Member
Author
|
Caretaker: g3 failures are unrelated/preexisting |
Contributor
|
This PR was merged into the repository by commit f00bf71. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 12, 2023
#48720) `makeEnvironmentProviders` constructs the wrapped `EnvironmentProviders` type, which can only be used in environment injectors (not element injectors). It makes sense that `makeEnvironmentProviders` should be able to accept existing `EnvironmentProviders`-wrapped providers, since it will be providing the same guarantee, but the current types do not allow this. This commit fixes the typings to allow nesting `EnvironmentProviders` and adds a test to verify that it will work. PR Close #48720
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 19, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.0/15.1.1) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.0/15.1.1) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.0/15.1.1) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.0/15.1.1) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.0/15.1.1) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.0/15.1.1) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.0/15.1.1) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.0/15.1.1) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v15.1.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1511-2023-01-18) [Compare Source](angular/angular@15.1.0...15.1.1) ##### common | Commit | Type | Description | | -- | -- | -- | | [68ce4f6ab4](angular/angular@68ce4f6) | fix | Update `Location` to get a normalized URL valid in case a represented URL starts with the substring equals `APP_BASE_HREF` ([#​48489](angular/angular#48489)) | | [032b2bd689](angular/angular@032b2bd) | perf | avoid excessive DOM mutation in NgClass ([#​48433](angular/angular#48433)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [dd54f6bd96](angular/angular@dd54f6b) | fix | makeEnvironmentProviders should accept EnvironmentProviders ([#​48720](angular/angular#48720)) | #### Special Thanks Alan Agius, Alex Rickabaugh, Andrew Scott, Aristeidis Bampakos, Bob Watson, Jens, Konstantin Kharitonov, Kristiyan Kostadinov, Matthieu Riegler, Paul Gschwendtner, Pawel Kozlowski, Vladyslav Slipchenko, ced, dario-piotrowicz, mgechev and ノウラ <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS41In0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1739 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
angular#48720) `makeEnvironmentProviders` constructs the wrapped `EnvironmentProviders` type, which can only be used in environment injectors (not element injectors). It makes sense that `makeEnvironmentProviders` should be able to accept existing `EnvironmentProviders`-wrapped providers, since it will be providing the same guarantee, but the current types do not allow this. This commit fixes the typings to allow nesting `EnvironmentProviders` and adds a test to verify that it will work. PR Close angular#48720
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeEnvironmentProvidersconstructs the wrappedEnvironmentProviderstype, which can only be used in environment injectors (not element injectors). It makes sense thatmakeEnvironmentProvidersshould be able to accept existingEnvironmentProviders-wrapped providers, since it will be providing the same guarantee, but the current types do not allow this.This commit fixes the typings to allow nesting
EnvironmentProvidersand adds a test to verify that it will work.