refactor(language-service): make selector nullable#48193
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
refactor(language-service): make selector nullable#48193crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
This is a follow-up from angular#48147. Changes the `DirectiveSymbol.selector` to be nullable since it's possible to have directives without a selector.
atscott
approved these changes
Nov 23, 2022
Contributor
|
This PR was merged into the repository by commit 0138d75. |
dylhunn
pushed a commit
that referenced
this pull request
Nov 23, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
This is a follow-up from angular#48147. Changes the `DirectiveSymbol.selector` to be nullable since it's possible to have directives without a selector. PR Close angular#48193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #48147. Changes the
DirectiveSymbol.selectorto be nullable since it's possible to have directives without a selector.