feat(router): Add ability to override onSameUrlNavigation default per-navigation
#48050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
CI is failing with circular deps, needs cleanup: https://app.circleci.com/pipelines/github/angular/angular/53072/workflows/40bddedb-89ad-4ae2-a6eb-fa9432f216b2/jobs/1254185 |
4b98388 to
9f0246d
Compare
9f0246d to
7186653
Compare
AndrewKushnir
approved these changes
Nov 18, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api, fw-router
dylhunn
approved these changes
Nov 21, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
|
merge assistance: pullapprove seems to be stuck |
Contributor
|
@atscott Would you be able to rebase this? |
7186653 to
d56c453
Compare
d56c453 to
c942e69
Compare
…er-navigation The router providers a configurable `onSameUrlNavigation` value that allows developers to configure whether navigations to the same URL as the current one should be processed or ignored. However, this only acts as a default value and there isn't an API for easily overriding this for a single navigation. Instead, developers are forced to update the value of the property on the router instance and remember to reset it. This feature fills a small gap in the Router APIs that enables developers to accomplish the task of force reloading a bit easier. Lengthy discussion about this here: angular#21115
c942e69 to
74b6631
Compare
Contributor
|
This PR was merged into the repository by commit 332461b. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…er-navigation (angular#48050) The router providers a configurable `onSameUrlNavigation` value that allows developers to configure whether navigations to the same URL as the current one should be processed or ignored. However, this only acts as a default value and there isn't an API for easily overriding this for a single navigation. Instead, developers are forced to update the value of the property on the router instance and remember to reset it. This feature fills a small gap in the Router APIs that enables developers to accomplish the task of force reloading a bit easier. Lengthy discussion about this here: angular#21115 PR Close angular#48050
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The router providers a configurable
onSameUrlNavigationvalue that allows developers to configure whether navigations to the same URL as the current one should be processed or ignored. However, this only acts as a default value and there isn't an API for easily overriding this for a single navigation. Instead, developers are forced to update the value of the property on the router instance and remember to reset it.This feature fills a small gap in the Router APIs that enables developers to accomplish the task of force reloading a bit easier.
Lengthy discussion about this here: #21115