Skip to content

docs: fix lint errors for change detection guides#47952

Closed
pjpscriv wants to merge 1 commit intoangular:mainfrom
pjpscriv:fix-guide-docs-lint-errors
Closed

docs: fix lint errors for change detection guides#47952
pjpscriv wants to merge 1 commit intoangular:mainfrom
pjpscriv:fix-guide-docs-lint-errors

Conversation

@pjpscriv
Copy link
Contributor

@pjpscriv pjpscriv commented Nov 3, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #47179

What is the new behavior?

Document lint errors resolved for the change detection guides section. Also solves one lint warning for the developer guides overview doc.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn November 3, 2022 04:59
@ngbot ngbot bot added this to the Backlog milestone Nov 3, 2022
dylhunn
dylhunn approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-core

@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Nov 3, 2022
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 4, 2022

This PR was merged into the repository by commit f01ea3c.

AndrewKushnir pushed a commit that referenced this pull request Nov 4, 2022
@pjpscriv @AndrewKushnir
docs: fix lint errors for change detection guides (#47952)
cc4f5e6 
PR Close #47952
AndrewKushnir pushed a commit that referenced this pull request Nov 4, 2022
@pjpscriv @AndrewKushnir
docs: fix lint errors for change detection guides (#47952)
6c940eb 
PR Close #47952
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 5, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2022
@pjpscriv pjpscriv deleted the fix-guide-docs-lint-errors branch January 29, 2023 23:38
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
@pjpscriv @trekladyone
docs: fix lint errors for change detection guides (angular#47952)
e145d8d 
PR Close angular#47952
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dylhunn dylhunn dylhunn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@pjpscriv @AndrewKushnir @dylhunn