perf(compiler-cli): minimize filesystem calls when generating shims#47682
Closed
clydin wants to merge 1 commit intoangular:mainfrom
Closed
perf(compiler-cli): minimize filesystem calls when generating shims#47682clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
Previously when a file was being analyzed to determine if a shim should be generated, up to two calls to the host `fileExists` function per file per generator were made. In the default host, each `fileExists` call made two underlying file system calls. Following these calls, the file was then read via `getSourceFile`. However, `getSourceFile` will return `undefined` if the requested file does not exist. As a result, `getSourceFile` can be used directly to request both potential file names and leverage the return value to determine if the file does not exist. This avoids the need to call `fileExists` at all.
JoostK
approved these changes
Oct 6, 2022
Member
JoostK
left a comment
There was a problem hiding this comment.
LGTM. I think this can go into patch instead of minor, can't it?
Contributor
|
This PR was merged into the repository by commit a792bf1. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Oct 7, 2022
…47682) Previously when a file was being analyzed to determine if a shim should be generated, up to two calls to the host `fileExists` function per file per generator were made. In the default host, each `fileExists` call made two underlying file system calls. Following these calls, the file was then read via `getSourceFile`. However, `getSourceFile` will return `undefined` if the requested file does not exist. As a result, `getSourceFile` can be used directly to request both potential file names and leverage the return value to determine if the file does not exist. This avoids the need to call `fileExists` at all. PR Close #47682
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.5/14.2.6) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.5/14.2.6) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.5/14.2.6) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.5/14.2.6) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.5/14.2.6) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.5/14.2.6) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.5/14.2.6) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.5` -> `14.2.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.5/14.2.6) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1426-2022-10-12) [Compare Source](angular/angular@14.2.5...14.2.6) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [3fd176a905](angular/angular@3fd176a) | fix | add missing period to error message ([#​47744](angular/angular#47744)) | | [c3821f5ab5](angular/angular@c3821f5) | perf | minimize filesystem calls when generating shims ([#​47682](angular/angular#47682)) | #### Special Thanks Alan Agius, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, Charles Lyding, Joey Perrott, Joshua Morony, Mathew Berg, Paul Gschwendtner, Peter Dickten, Renan Ferro, Sri Ram, WD Snoeijer, markostanimirovic and Álvaro Martínez <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjIzNi4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1582 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when a file was being analyzed to determine if a shim should be generated, up to two calls to the host
fileExistsfunction per file per generator were made. In the default host, eachfileExistscall made two underlying file system calls. Following these calls, the file was then read viagetSourceFile. However,getSourceFilewill returnundefinedif the requested file does not exist. As a result,getSourceFilecan be used directly to request both potential file names and leverage the return value to determine if the file does not exist. This avoids the need to callfileExistsat all.