Skip to content

build: update Angular tooling packages to 15.0.0-next.3#47584

Closed
alan-agius4 wants to merge 4 commits intoangular:mainfrom
alan-agius4:deps-tooling-cli
Closed

build: update Angular tooling packages to 15.0.0-next.3#47584
alan-agius4 wants to merge 4 commits intoangular:mainfrom
alan-agius4:deps-tooling-cli

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Sep 29, 2022

@alan-agius4 alan-agius4 force-pushed the deps-tooling-cli branch 2 times, most recently from 22a0e59 to 68182c2 Compare September 29, 2022 12:04
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release area: build & ci Related the build and CI infrastructure of the project labels Sep 29, 2022
@ngbot ngbot bot added this to the Backlog milestone Sep 29, 2022
@alan-agius4 alan-agius4 force-pushed the deps-tooling-cli branch 6 times, most recently from eae419b to 8d86bef Compare September 29, 2022 15:33
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 29, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review September 29, 2022 15:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🎉 @alan-agius4 do we know which change caused the payload size decrease?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now output es2022 by default and only downlevel features that are needed to be downlevelled based on the supported browsers.

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: size-tracking

Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: zone.js
LGTM

Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: zone.js
LGTM

@pullapprove pullapprove bot requested a review from JiaLiPassion September 30, 2022 06:02
Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- This update is needed to implement the changes in `ng add localize` angular#47569
- Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail.
- Remove `require.context` from test.ts integration test, as this is no longer needed.
- Update payloads golden files.
This is needed as Angular does not support Chrome 93.
This does not provide any added value.
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Sep 30, 2022
@alan-agius4
Copy link
Contributor Author

Caretaker: Github is not allowing me to remove the pending reviewers even though the current approvals suffice.

@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit ce59f1a.

AndrewKushnir pushed a commit that referenced this pull request Sep 30, 2022
This is needed as Angular does not support Chrome 93.

PR Close #47584
AndrewKushnir pushed a commit that referenced this pull request Sep 30, 2022
This does not provide any added value.

PR Close #47584
@alan-agius4 alan-agius4 deleted the deps-tooling-cli branch September 30, 2022 17:55
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
)

- This update is needed to implement the changes in `ng add localize` angular#47569
- Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail.
- Remove `require.context` from test.ts integration test, as this is no longer needed.
- Update payloads golden files.

PR Close angular#47584
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
This is needed as Angular does not support Chrome 93.

PR Close angular#47584
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
)

- This update is needed to implement the changes in `ng add localize` angular#47569
- Add missing `root` options to all `angular.json`, this is required as otherwise the angular.json validation will fail.
- Remove `require.context` from test.ts integration test, as this is no longer needed.
- Update payloads golden files.

PR Close angular#47584
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
This is needed as Angular does not support Chrome 93.

PR Close angular#47584
pterratpro pushed a commit to pterratpro/angular-fr that referenced this pull request Oct 4, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants