Skip to content

docs: fixing standalone components sample code#47542

Closed
ashley-hunter wants to merge 1 commit intoangular:mainfrom
ashley-hunter:patch-1
Closed

docs: fixing standalone components sample code#47542
ashley-hunter wants to merge 1 commit intoangular:mainfrom
ashley-hunter:patch-1

Conversation

@ashley-hunter
Copy link

@ashley-hunter ashley-hunter commented Sep 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The standalone components example code for library authors is not valid JavaScript.

Issue Number: N/A

What is the new behavior?

Adding the missing the 'const' keyword.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Sep 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from jessicajaniuk September 25, 2022 11:44
@ngbot ngbot bot added this to the Backlog milestone Sep 25, 2022
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 26, 2022
@alxhub
Copy link
Member

alxhub commented Sep 26, 2022

This PR was merged into the repository by commit f9e21d3.

@alxhub alxhub closed this in f9e21d3 Sep 26, 2022
alxhub pushed a commit that referenced this pull request Sep 26, 2022
@ashley-hunter ashley-hunter deleted the patch-1 branch September 26, 2022 18:34
sonukapoor pushed a commit to sonukapoor/angular that referenced this pull request Sep 27, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants